Sitelet https://web.archive.org/web/20210104141303/https://github.com/bazelbuild/rules_python/pull/369
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README update (related to 0.1.0 release) #369

Merged
merged 2 commits into from Oct 16, 2020

Conversation

@thundergolfer
Copy link
Collaborator

@thundergolfer thundergolfer commented Oct 15, 2020 •

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features) N/A
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…te', remove 'git_repository' usage
@thundergolfer thundergolfer requested a review from andyscott as a code owner Oct 15, 2020
@google-cla google-cla bot added the cla: yes label Oct 15, 2020
@thundergolfer thundergolfer requested a review from alexeagle Oct 15, 2020
git_repository(
http_archive(

This comment has been minimized.

@thundergolfer

thundergolfer Oct 15, 2020
Author Collaborator

http_archive is preferred over git_repository. See: https://docs.bazel.build/versions/master/external.html#repository-rules

@@ -5,6 +5,11 @@

## Recent updates

* 2020-10-15: Release [`0.1.0` was published](https://github.com/bazelbuild/rules_python/releases/tag/0.1.0), upstreaming
the `pip_install` rule functionality from [github.com/dillon-giacoppo/rules_python_external](https://github.com/dillon-giacoppo/rules_python_external)
to address a number of long-standing issues with `pip_import` (eg. [#96](https://github.com/bazelbuild/rules_python/issues/96), [#71](https://github.com/bazelbuild/rules_python/issues/71), [#102](https://github.com/bazelbuild/rules_python/issues/102)).

This comment has been minimized.

@alexeagle

alexeagle Oct 16, 2020
Collaborator

note, I don't think you need to spell out these links, a bare #96 gets formatted this way in GH markdown IIUC

@alexeagle alexeagle merged commit 5c948dc into master Oct 16, 2020
2 checks passed
2 checks passed
buildkite/rules-python-python Build #1128 passed (54 seconds)
Details
cla/google All necessary CLAs are signed
@thundergolfer thundergolfer deleted the joanthon--README-update-2020-10-15 branch Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.