remove wrapper_ from napi_wrap examples #151
Open
Conversation
Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Fixes: #140
904b9b2
to
5c94d85
|
I'm wondering if it it still makes sense for an example to show how you can use one of the parameters even if its not really fully used. @gabrielschulhof what's your take on that? |
|
@gabrielschulhof ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The variable is only ever assigned and then cleaned up, never used.