Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upTotal result count (nbHits) not updated for filters #764
Comments
|
This is a good suggestion. Currently, we only report the number of candidates, not accounting for the filtered elements. We could in fact count the filtered out element and take them out of the candidate count. |
|
+1 |
|
@MarinPostma, Now that I'm done with the tests cleanup, I would be interested in picking this up, if it is still available. |
|
Amazing! There are multiple places where this have to be done unfortunately... Ping me on slack during the week, and I'll show you where to look |
|
Awesome! I'll have a look and ping you for sure. |
|
I tried looking at this a bit myself as I'm trying to migrate to meilisearch from algolia, and I didn't find an easy solution. I'm to big of a Rust newb to actually tackle this without a bit more time to learn some things. I think this issues should also qualify as a bug, because paginators that rely on total counts simply don't work when filtered with the current implementation. Anyway just wanted to make a comment to support this enhancement. Thanks! |
Is your feature request related to a problem? Please describe.
I want to show the number of total results (for pagination and for feedback to my users). The result field nbHits is updated by the search string but is not updated by the filters that are given. Because of that it is impossible to give a total count to the users and make a good pagination.
Describe the solution you'd like
It would be nice if nbHits is also updated by filters or if there is a secord variable where the filtered count is shown.