Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcustom record support #94
Closed
Conversation
|
hmm, I did not notice that you have made the change on your own yesterday. So the pull request is obsolete now. |
|
Sorry about the duplicate effort. I didn't realize you were already working on it since you mentioned you might need some time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi Ingo,
as discussed via e-mail, I hereby submit a patch that allows the use of own record implementations for "private use" record types. As some kind of a by-product I extended the idea somewhat so that also included record types can be overridden (although I have no use for it at the moment). As always, if there is anything that needs to be fixed from your perspective, please let me know.