Sitelet https://web.archive.org/web/20220320201404/https://github.com/angular/angular/pull/39347
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): incorrect signature for createUrlTree #39347

Closed
wants to merge 1 commit into from
Closed

fix(router): incorrect signature for createUrlTree #39347

wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 20, 2020 •
edited

The type of the navigationExtras param was accidentally changed to the wrong symbol in 783a5bd.
These changes revert it to the correct one.

@crisbeto
fix(router): incorrect signature for createUrlTree
4e0ccaf 
The type of the `navigationExtras` param was accidetally changed to the wrong symbol
in angular@783a5bd.
These changes revert it to the correct one.
@google-cla google-cla bot added the cla: yes label Oct 20, 2020
@pullapprove pullapprove bot requested a review from atscott Oct 20, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 20, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 20, 2020
@ngbot ngbot bot added this to the needsTriage milestone Oct 20, 2020
atscott
atscott approved these changes Oct 20, 2020
View changes
Copy link
Contributor

@atscott atscott left a comment

reviewed-for: public-api
reviewed-for: fw-router

jelbourn
jelbourn approved these changes Oct 20, 2020
View changes
Copy link
Member

@jelbourn jelbourn left a comment

LGTM

Reviewed-for: public-api

@pullapprove pullapprove bot requested a review from AndrewKushnir Oct 20, 2020
AndrewKushnir
AndrewKushnir approved these changes Oct 20, 2020
View changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Reviewed-for: public-api

AndrewKushnir added a commit that referenced this issue Oct 20, 2020
@crisbeto @AndrewKushnir
fix(router): incorrect signature for createUrlTree (#39347)
161b278 
The type of the `navigationExtras` param was accidetally changed to the wrong symbol
in 783a5bd.
These changes revert it to the correct one.

PR Close #39347
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Nov 20, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@atscott atscott

@jelbourn jelbourn

@AndrewKushnir AndrewKushnir

Assignees
No one assigned
Labels
action: merge cla: yes comp: router target: rc type: bug/fix
Projects
None yet
Milestone
needsTriage
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisbeto @atscott @jelbourn @AndrewKushnir