Sitelet https://web.archive.org/web/20200918071808/https://github.com/maartenbreddels/ipyvolume/issues/238
Skip to content

/ ipyvolume

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Chrome headless location and port configurable #238

Open
razorx89 opened this issue Mar 15, 2019 · 1 comment
Open

Make Chrome headless location and port configurable #238

razorx89 opened this issue Mar 15, 2019 · 1 comment
Labels
enhancement good first issue

Comments

@razorx89
Copy link

@razorx89 razorx89 commented Mar 15, 2019

Currently, the headless mode uses default parameters from PyChromeDevTools for connecting to a chrome headless instance.

ipyvolume/ipyvolume/headless.py

Line 53 in e68b728

chrome = PyChromeDevTools.ChromeInterface()

However, if you use a chrome headless running as docker instance and want to connect from another docker instance (e.g. when using docker-compose), the headless instance is no longer located at localhost or 127.0.0.1. ipv.savefig and ipv.screenshot should both accept headless configuration parameters, for instance headless_kwargs=None and pass it to the
PyChromeDevTools(**(headless_kwargs or {})).
@maartenbreddels
Copy link
Owner

@maartenbreddels maartenbreddels commented Apr 24, 2019

That is a very good idea, PR welcome, otherwise, I keep this open as a reminder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@maartenbreddels @razorx89
You can’t perform that action at this time.