Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix enum34 requirement in setup.py for python 3 #289
Closed
Conversation
|
Thank you, we'll incorporate this change |
|
Merged in 878b8d8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The preferred way to specify a requirement that depends on python version is to do something like
'<packagename>; python_version < "3.4"', not to do the sys.version check as is currently being done.I am running into an issue where a wheel is built with py2 and the cached wheel metadata is used again when installing the package for python 3.7, thus incorrectly including
enum34.This same issue is addressed in the stack overflow responses here