Actions: Add missing runs-on (managing complex workflows)#667
Merged
lucascosti merged 2 commits intogithub:mainfrom Nov 4, 2020
Merged
Actions: Add missing runs-on (managing complex workflows)#667lucascosti merged 2 commits intogithub:mainfrom
lucascosti merged 2 commits intogithub:mainfrom
Conversation
Also fix indentation in another example
Contributor
|
Thanks @Simran-B! I'll get this triaged for review 🌟 |
lucascosti
approved these changes
Nov 4, 2020
Contributor
lucascosti
left a comment
There was a problem hiding this comment.
Yep, correct for both examples. Thanks again for these fixes, @Simran-B! 🚀
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix indentation in another example
Why:
The adjacent jobs have
runs-onkeys. The one job missing it caused confusion:https://github.community/t/reusing-sharing-inheriting-steps-between-jobs-declarations/16851/19?u=simran-b
What's being changed:
Add
runs-on: ubuntu-latest. Also fix indentation in another example.Check off the following: