Sitelet https://web.archive.org/web/20220320201316/https://github.com/angular/angular/pull/39320
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-cli): report missing pipes when fullTemplateTypeCheck is disabled #39320

Closed
wants to merge 1 commit into from
Closed

fix(compiler-cli): report missing pipes when fullTemplateTypeCheck is disabled #39320

wants to merge 1 commit into from

Conversation

JoostK
Copy link
Member

@JoostK JoostK commented Oct 17, 2020

Even if fullTemplateTypeCheck is disabled should missing pipes still
be reported, as was the case in View Engine.

Fixes #38195

@ngbot ngbot bot added this to the needsTriage milestone Oct 17, 2020
@google-cla google-cla bot added the cla: yes label Oct 17, 2020
@JoostK JoostK mentioned this pull request Oct 17, 2020
Closed
15 tasks
@JoostK
fix(compiler-cli): report missing pipes when fullTemplateTypeCheck …
c4d950c 
…is disabled

Even if `fullTemplateTypeCheck` is disabled should missing pipes still
be reported, as was the case in View Engine.

Fixes angular#38195
@JoostK JoostK force-pushed the ngtsc/report-missing-pipes branch from 0dd4bdf to c4d950c Compare Oct 17, 2020
@JoostK JoostK marked this pull request as ready for review Oct 17, 2020
@JoostK JoostK requested a review from alxhub Oct 17, 2020
alxhub
alxhub approved these changes Oct 30, 2020
View changes
josephperrott added a commit that referenced this issue Oct 31, 2020
@JoostK @josephperrott
fix(compiler-cli): report missing pipes when fullTemplateTypeCheck …
71d0063 
…is disabled (#39320)

Even if `fullTemplateTypeCheck` is disabled should missing pipes still
be reported, as was the case in View Engine.

Fixes #38195

PR Close #39320
josephperrott added a commit that referenced this issue Oct 31, 2020
@JoostK @josephperrott
fix(compiler-cli): report missing pipes when fullTemplateTypeCheck …
67ea7b6 
…is disabled (#39320)

Even if `fullTemplateTypeCheck` is disabled should missing pipes still
be reported, as was the case in View Engine.

Fixes #38195

PR Close #39320
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Dec 1, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxhub alxhub

Assignees
No one assigned
Labels
action: merge action: presubmit cla: yes comp: compiler engine: ivy target: patch type: bug/fix
Projects
None yet
Milestone
needsTriage
Linked issues

Successfully merging this pull request may close these issues.

Missing pipe not caught by production build with AOT
2 participants
@JoostK @alxhub