JS: avoid using getFirstToken for sorting#4486
Merged
Merged
Conversation
asgerf
approved these changes
Oct 21, 2020
asgerf
left a comment
Contributor
There was a problem hiding this comment.
Nice! It makes sense as getFirstToken() is derived from location info anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A while ago a bad join order inspired me to look into
getFirstTokenand where we use it.We use it in a few places to sort expression by when they appear in a file.
But it looks like performance is better when we sort by
Locationinstead ofgetFirstToken.So I changed the places where we sorted based on
getFirstToken.Here is an evaluation.
(average of three nightly runs, of which one was on my laptop, all evaluations saw a speedup).
Looks like we get a small performance improvement in the neighborhood of 1%.