-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Labels
good first issueThis is a good issue if you want to start working on PyInstallerThis is a good issue if you want to start working on PyInstallerpull-request wantedPlease submit a pull-request for this, maintainers will not actively work on this.Please submit a pull-request for this, maintainers will not actively work on this.
Description
If a hook as an excludedimports entry, this currently leads to duplicate log entries:
INFO PyInstaller.depend.imphook:imphook.py:576 Excluding import 'argparse'
INFO PyInstaller.depend.imphook:imphook.py:596 Removing import of argparse from module pickle
INFO PyInstaller.depend.imphook:imphook.py:576 Excluding import 'doctest'
INFO PyInstaller.depend.imphook:imphook.py:596 Removing import of doctest from module pickle
I suggest merging them into
INFO PyInstaller.depend.imphook:imphook.py:576 Excluding import 'argparse' from module pickle
INFO PyInstaller.depend.imphook:imphook.py:576 Excluding import 'doctest' from module pickle
Still one line per excluded import, though.
If there are good reasons to keep both log lines per excluded import, keep both :-)
Legorooj and ahmedelfateh
Metadata
Metadata
Assignees
Labels
good first issueThis is a good issue if you want to start working on PyInstallerThis is a good issue if you want to start working on PyInstallerpull-request wantedPlease submit a pull-request for this, maintainers will not actively work on this.Please submit a pull-request for this, maintainers will not actively work on this.