GitHub is sending us PR synchronize event for a PR that does not exist. #109

Mariatta · 2018-06-11T21:32:31Z

Same issue as described in python/the-knights-who-say-ni#148.
Bedevere is attempting to apply a label to such PR, causing gidgethub.BadRequest: Not Found error.

bedevere/bedevere/bpo.py

Lines 35 to 42 in 7cd16ef

    
           @router.register("pull_request", action="opened") 
        
           @router.register("pull_request", action="synchronize") 
        
           async def set_status(event, gh, *args, **kwargs): 
        
               """Set the issue number status on the pull request.""" 
        
               issue_number_found = ISSUE_RE.search(event.data["pull_request"]["title"]) 
        
               if not issue_number_found: 
        
                   issue = await util.issue_for_PR(gh, event.data["pull_request"]) 
        
                   status = SKIP_ISSUE_STATUS if util.skip("issue", issue) else FAILURE_STATUS

Perhaps we can catch the error here, so I won't keep getting error alerts.
Thanks.

brettcannon · 2018-06-12T19:21:35Z

Yep, if GitHub gives us bad data then we should log that fact and then move on.

Mariatta · 2018-06-18T21:44:41Z

🍝 (copy pasta 😄)

Update from GitHub:

PR 5581 exists, but it just has been marked as "suspicious/spammy", so we and the bots can't access it. The PR was still open and we were receiving the "synchronize" events, breaking the bots.

I have asked GitHub to close the PR, and it has been closed now.

We can still improve the code though if this ever happens again :)

lysnikolaou · 2019-10-12T14:42:33Z

@brettcannon @Mariatta How do you think the right approach for this would be? Should we wrap every call to post with a try/except, where we log the event (which would be a bigger change) or maybe just do that for the code in set_status?

brettcannon · 2019-10-18T21:56:25Z

@lysnikolaou this definitely isn't a priority to fix, but yes, a well-documents try/except with a tight except clause would be the way to handle it.

brettcannon added the enhancement label Apr 23, 2019

python / bedevere

GitHub is sending us PR synchronize event for a PR that does not exist. #109

GitHub is sending us PR synchronize event for a PR that does not exist. #109

Mariatta commented Jun 11, 2018

brettcannon commented Jun 12, 2018

Mariatta commented Jun 18, 2018

lysnikolaou commented Oct 12, 2019 •

edited

brettcannon commented Oct 18, 2019

python / bedevere

Join GitHub today

GitHub is sending us PR synchronize event for a PR that does not exist. #109

GitHub is sending us PR synchronize event for a PR that does not exist. #109

Comments

Mariatta commented Jun 11, 2018

brettcannon commented Jun 12, 2018

Mariatta commented Jun 18, 2018

lysnikolaou commented Oct 12, 2019 • edited

brettcannon commented Oct 18, 2019

Essential cookies

Always active

Analytics cookies

lysnikolaou commented Oct 12, 2019 •

edited