Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGoogle Services 4.3.0 must now add DisableVersionCheck = true #11168
Comments
|
Hello! Would I be able to take this issue? |
|
@xaylax Go ahead! What counts the most is the PR. |
|
@StorytellerCZ quick question, I'm a first time contributor so I'm not as experienced with the code base, but the ticket says to add the |
|
@xaylax I'm not familiar with the Cordova part, that will be someone like @filipenevola , but until he shows up. Let's see what I we can figure out together. I'll take a look tomorrow on the code base (as it is super late for me as I write this), but there is probably going to be some sort of generation for the |
|
hi @StorytellerCZ , I dug around and found all these files, and they all have an "apply" line (like the ticket mentioned), and some have multiple lines with "apply", is there a certain file that I need to add the line to, or would I need to add the line to all these files? Thanks! |
I have been having conflict issues with incompatible versions of google plugins, and have pulled together as much information as I can find, I have removed the gradle plugin from pre Cordova 9
cordova-android-support-gradle-release@3.0.1 - removed now included in Cordova 9.+
and have added to mobile-config.js
App.setPreference('AndroidXEnabled', 'true', 'android');
App.setPreference('GradlePluginGoogleServicesEnabled', true);
App.setPreference('GradlePluginGoogleServicesVersion', '4.3.3');
from what I have found which has lots of likes and praise adding the disableversioncheck to build.gradle
not sure how to apply these setting but they would seemingly solve compatibility issues.
"Starting with com.google.gms:google-services:4.3.0 you must now instead add the following to the bottom of your app/build.gradle, after the apply.
googleServices { disableVersionCheck = true }
This also works with previous version of com.google.gms:google-services."
OneSignal/OneSignal-Gradle-Plugin#37 (comment)