Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRework "user groups" widget to work like other organization-level settings widgets #16453
Comments
|
@zulipbot claim |
Fixes: zulip#16453 Changed Click outside to save and discard to discard UI of user_group origanization settings to save/discard widget to maintain consistency.
Fixes: zulip#16453 Changed Click outside to save and discard to discard UI of user_group origanization settings to save/discard widget to maintain consistency.
Fixes: zulip#16453 User Groups were saved one at a time and reloaded each time. Changed this by allowing simutaneous changes at multiple user_groups.
|
@zulipbot claim |
|
@mandepsingh I am working on the task already. There is some issue with zulipbot I guess. |
Fixes: zulip#16453 User Groups were discarded one at a time and reloaded each time. Changed this by allowing simutaneous discards,save at multiple user_groups.
|
@zulipbot claim |
|
Welcome to Zulip, @shubham00jain! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
|
@savish28 are you still working on this issue? |
|
I have worked on the issue and waiting for pr review. Past that only testfiles need to be changed. |
|
Okay. It was unassigned so I thought that you have stopped working on it. |
|
@zulipbot abandon |
|
@zulipbot claim |
Specifically, we should use the normal Save/Discard widget that we use across all of "organization settings", rather than the custom inconsistent "Click outside to save or click discard to discard" UI that it currently has.