Sitelet https://web.archive.org/web/20220519001918/https://github.com/angular/components/pull/20748
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(material/table): add multiTemplateDataRows specification #20748

Merged
merged 1 commit into from Oct 14, 2020
Merged

docs(material/table): add multiTemplateDataRows specification #20748

merged 1 commit into from Oct 14, 2020

Conversation

geromegrignon
Copy link
Contributor

@geromegrignon geromegrignon commented Oct 8, 2020 •
edited

Purpose

Add a section to material/table documentation about how to retrieve the index of a row when using the multiTemplateDataRows directive. This information is only accessible as a comment into the row.ts file of the cdk.


        Context provided to the row cells when multiTemplateDataRows is true. This context is the same
        as CdkCellOutletRowContext except that the single index value is replaced by dataIndex and
        renderIndex.

Motivation

Having notifications over time about a related issue i gave an answer 2 years ago.

Issue #12793

@geromegrignon geromegrignon requested a review from andrewseguin as a code owner Oct 8, 2020
@google-cla google-cla bot added the cla: yes label Oct 8, 2020
crisbeto
crisbeto approved these changes Oct 9, 2020
View changes
Copy link
Member

@crisbeto crisbeto left a comment

LGTM with one minor comment.

src/material/table/table.md Outdated Show resolved Hide resolved
@crisbeto crisbeto added docs merge ready merge safe target: patch labels Oct 11, 2020
@annieyw annieyw merged commit 91a9355 into angular:master Oct 14, 2020
16 checks passed
annieyw pushed a commit that referenced this issue Oct 14, 2020
@geromegrignon @annieyw
docs(material/table): add multiTemplateDataRows specification (#20748)
33aa531 
add a section about index

(cherry picked from commit 91a9355)
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Nov 14, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto

@andrewseguin andrewseguin

Assignees
No one assigned
Labels
cla: yes docs merge ready merge safe target: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@geromegrignon @crisbeto @annieyw