fix(cdk/drag-drop): references to SVG not working inside preview #20742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we create a drag preview we clone the original element, move it to the bottom of the `body`, set it to `display: none` and clear all `id` attributes from the clone. As a result, SVG references inside the element break, because the source node is invisible. These changes resolve the issue by moving the original element outside the layout and making it invisible, instead of using `display: none`. Fixes angular#20720.
annieyw
pushed a commit
that referenced
this issue
Oct 16, 2020
) When we create a drag preview we clone the original element, move it to the bottom of the `body`, set it to `display: none` and clear all `id` attributes from the clone. As a result, SVG references inside the element break, because the source node is invisible. These changes resolve the issue by moving the original element outside the layout and making it invisible, instead of using `display: none`. Fixes #20720. (cherry picked from commit 06294d1)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When we create a drag preview we clone the original element, move it to the bottom of the
body, set it todisplay: noneand clear allidattributes from the clone. As a result, SVG references inside the element break, because the source node is invisible.These changes resolve the issue by moving the original element outside the layout and making it transparent, instead of using
display: none.Fixes #20720.