Sitelet https://web.archive.org/web/20201006025320/https://github.com/go-gitea/gitea/issues/12948
Skip to content

/ gitea

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check URL on Create OpenID Connect provider #12948

Open
6543 opened this issue Sep 26, 2020 · 1 comment
Open

Check URL on Create OpenID Connect provider #12948

6543 opened this issue Sep 26, 2020 · 1 comment
Labels
Hacktoberfest good first issue kind/bug kind/enhancement

Comments

@6543
Copy link
Member

@6543 6543 commented Sep 26, 2020

source: #9833 (comment)

"...some feedback on whether the URL is correct (like checking the response of the URL to see that it does return something that looks like a .well-known/openid-configuration) rather than blindly accepting the URL would be a big improvement in user experience."
@6543 6543 mentioned this issue Sep 26, 2020
Closed
2 of 7 tasks complete
@siddhant94
Copy link

@siddhant94 siddhant94 commented Oct 3, 2020

Hey @techknowlogick @zeripath , auto-discover-url is being used in runAddOauth() & runUpdateOauth() . I was thinking of adding check for valid URL in parseOAuth2Config() so that it could be in a single place for everybody to use, but only runAddOauth() uses this parse method. So any suggestions regarding where the check could be placed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest good first issue kind/bug kind/enhancement
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@techknowlogick @zeripath @siddhant94 @6543
You can’t perform that action at this time.