Sitelet https://web.archive.org/web/20201005181014/https://github.com/electron/electron/pull/24495
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: tsify asar and move to webpack js2c pipeline #24495

Merged
merged 2 commits into from Jul 16, 2020
Merged

Conversation

@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Jul 10, 2020

Converts the asar init scripts to typescript and move them to be processed by our webpack --> js2c pipeline.

Notes: no-notes

@MarshallOfSound MarshallOfSound requested review from nornagon and codebytere Jul 10, 2020
@MarshallOfSound MarshallOfSound force-pushed the tsify-asar branch 2 times, most recently from 2bfa28f to 328a290 Jul 10, 2020
BUILD.gn Outdated Show resolved Hide resolved
lib/asar/fs-wrapper.ts Outdated Show resolved Hide resolved
Copy link
Member

@nornagon nornagon left a comment •

so much any 😭

i had a stab at this last week with less any and ended up finding bugs in the node typings (DefinitelyTyped/DefinitelyTyped#45783), so eh

lib/asar/fs-wrapper.ts Show resolved Hide resolved
lib/asar/fs-wrapper.ts Outdated Show resolved Hide resolved
@MarshallOfSound MarshallOfSound force-pushed the tsify-asar branch from 328a290 to 5a83e5b Jul 11, 2020
@MarshallOfSound
Copy link
Member Author

@MarshallOfSound MarshallOfSound commented Jul 11, 2020

Updated with strongly typed bindings

@MarshallOfSound MarshallOfSound merged commit f649e60 into master Jul 16, 2020
12 of 15 checks passed
12 of 15 checks passed
appveyor: win-ia32-testing AppVeyor build failed
Details
build-linux Workflow: build-linux
Details
Artifact Comparison
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-woa-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20200711.3 succeeded
Details
electron-arm64-testing Build #20200711.3 succeeded
Details
electron-woa-testing Build #20200711.2 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jul 16, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the tsify-asar branch Jul 16, 2020
georgexu99 pushed a commit to georgexu99/electron that referenced this pull request Jul 28, 2020
* build: tsify asar and move to webpack js2c pipeline

* build: use the webpack provider for fs-wrapper
georgexu99 pushed a commit to georgexu99/electron that referenced this pull request Jul 28, 2020
* build: tsify asar and move to webpack js2c pipeline

* build: use the webpack provider for fs-wrapper
sentialx added a commit to sentialx/electron that referenced this pull request Jul 30, 2020
* build: tsify asar and move to webpack js2c pipeline

* build: use the webpack provider for fs-wrapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.