Sitelet https://web.archive.org/web/20201006213747/https://github.com/TheAlgorithms/Python/pull/2735
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create file_utils.py #2735

Open
wants to merge 7 commits into
base: master
from
Open

Create file_utils.py #2735

wants to merge 7 commits into from

Conversation

@MonarchChakri
Copy link

@MonarchChakri MonarchChakri commented Oct 4, 2020

Utility file helpful for file I/O in python3.
Helps for plain text IO and JSON load and dump.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
@MonarchChakri
Create file_utils.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
35faf3c 
Utility file helpful for file I/O in python3.
Helps for plain text IO and JSON load and dump.
@MonarchChakri
Update file_utils.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5d9f968 
Updated to make it compatible with black
@MonarchChakri MonarchChakri mentioned this pull request Oct 4, 2020
Open
0 of 2 tasks complete
@MonarchChakri
Copy link
Author

@MonarchChakri MonarchChakri commented Oct 4, 2020

Hi @cclauss / @poyea
Added file_utils.py under others and created this PR for #2510
A utility files helpful for all common file IO.
Please review and merge.
@cclauss
cclauss reviewed Oct 4, 2020
View changes
other/file_utils.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Oct 4, 2020
View changes
other/file_utils.py Outdated Show resolved Hide resolved
@cclauss
cclauss reviewed Oct 4, 2020
View changes
other/file_utils.py Outdated Show resolved Hide resolved
@MonarchChakri
Copy link
Author

@MonarchChakri MonarchChakri commented Oct 4, 2020

@cclauss
Will make the changes and update the file
MonarchChakri and others added 5 commits Oct 4, 2020
@MonarchChakri @cclauss
Update other/file_utils.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d15d4af 
Co-authored-by: Christian Clauss <cclauss@me.com>
@MonarchChakri @cclauss
Update other/file_utils.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
dc47da2 
Co-authored-by: Christian Clauss <cclauss@me.com>
@MonarchChakri
Added type hints, docstrings and removed prints
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4078ae2
@MonarchChakri
Update file_utils.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fd07da2 
Correcting black and flake8 changes
@MonarchChakri
Update file_utils.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9398b70 
black: Single space after file_name
@MonarchChakri
Copy link
Author

@MonarchChakri MonarchChakri commented Oct 4, 2020

@cclauss
Updated the file, please review
@MonarchChakri MonarchChakri requested a review from cclauss Oct 4, 2020
@MonarchChakri
Copy link
Author

@MonarchChakri MonarchChakri commented Oct 5, 2020

@poyea
Can you also please approve and merge. 😅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@MonarchChakri @cclauss @poyea
You can’t perform that action at this time.