Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck the whitespace of pull requests on Travis #2367
Conversation
|
Since this will block PRs from being submitted if I get this wrong I won't be merging it until someone can provide me an approving review. |
|
One minor suggestion regarding the failure message, but the actual check looks good to me. |
| if not fixed: | ||
| print('No whitespace issues found') | ||
| else: | ||
| print(f'Please fix the {len(fixed)} file(s) with whitespace issues') |
ncoghlan
Jun 24, 2017
Contributor
Perhaps specifically mention make patchcheck here? It won't help Windows devs, but it's the easiest option elsewhere.
Perhaps specifically mention make patchcheck here? It won't help Windows devs, but it's the easiest option elsewhere.
|
GH-2386 is a backport of this pull request to the 3.6 branch. |
|
GH-2387 is a backport of this pull request to the 3.5 branch. |
|
Thanks @brettcannon for the PR |
|
Sorry, @brettcannon, I could not cleanly backport this to |
Closes python/core-workflow#3.