Sitelet https://web.archive.org/web/20200929164748/https://github.com/zulip/zulip/issues/16080
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate organization button is not disabled for regular users #16080

Open
Gittenburg opened this issue Aug 9, 2020 · 5 comments · May be fixed by #16104
Open

Deactivate organization button is not disabled for regular users #16080

Gittenburg opened this issue Aug 9, 2020 · 5 comments · May be fixed by #16104

Comments

@Gittenburg
Copy link
Collaborator

@Gittenburg Gittenburg commented Aug 9, 2020 •

Can be reproduced at https://chat.zulip.org/#organization/organization-profile.

I think this is a regression ... I remember the button being disabled before.

@zulipbot
Copy link
Member

@zulipbot zulipbot commented Aug 9, 2020

Hello @zulip/server-settings members, this issue was labeled with the "area: settings (admin/org)" label, so you may want to check it out!

@timabbott
Copy link
Member

@timabbott timabbott commented Aug 10, 2020

Yeah agreed it's a regression.

@Jagansivam28
Copy link
Collaborator

@Jagansivam28 Jagansivam28 commented Aug 10, 2020

@zulipbot claim

Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
We need to disable the deactivate organization button all other users
other than owner But currently, we are showing deactivate button for
regular users also. This commit fixes the bug.
fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
We need to disable the deactivate organization button all other users
other than owner But currently, we are showing deactivate button for
regular users also. This commit fixes the bug.
fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
We need to disable the deactivate organization button all other users
other than owner But currently, we are showing deactivate button for
regular users also. This commit fixes the bug.
fixes zulip#16080
@Jagansivam28 Jagansivam28 linked a pull request that will close this issue Aug 11, 2020
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug.
fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug by replacing `[disabled="disabled"]` with `[disabled]` since we are accessing ‘disabled’ as a property, not an attribute.
fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 11, 2020
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug by replacing
`[disabled="disabled"]` with `[disabled]` since we are accessing ‘disabled’
as a property, not an attribute.
fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 14, 2020
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug by replacing
`[disabled="disabled"]` with `[disabled]` since we are accessing ‘disabled’ as a property, not an attribute.
Fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 25, 2020
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug by replacing
`[disabled="disabled"]` with `[disabled]` since we are accessing ‘disabled’ as a property, not an attribute.
Fixes zulip#16080
Jagansivam28 added a commit to Jagansivam28/zulip that referenced this issue Aug 26, 2020
We need to disable the deactivate organization button for all other
users other than owner But currently, we are showing deactivate button
for regular users also. This commit fixes the bug by replacing
`[disabled="disabled"]` with `[disabled]` since we are accessing ‘disabled’ as a property, not an attribute.
Fixes zulip#16080
@zulipbot
Copy link
Member

@zulipbot zulipbot commented Sep 8, 2020 •

Hello @Jagansivam28, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@jakharrahul000
Copy link

@jakharrahul000 jakharrahul000 commented Sep 18, 2020

Hi @timabbott and @Gittenburg, I am new to this community and was looking to contribute.
I saw the issue, and it seems the button is already disabled, it does nothing on click, however it does change the color of the button, if you are addressing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.