JS: type-track objects where the "$where" property has been written#4342
Merged
Conversation
asgerf
approved these changes
Sep 29, 2020
Contributor
asgerf
left a comment
There was a problem hiding this comment.
LGTM
I've confirmed that API graphs would have given us this "for free" using getMember("$where").getRhs() on the relevant node 🎉 . But that's blocked on porting the NoSQL library to API graphs, so I think it's ok to land this PR as it is.
Contributor
|
But if you want to port the NoSQL library to API graphs that would also be great 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets a TP for
js/code-injectionon this synthetic benchmark.An alternative would be to add a
$wherestep as an additional taint step (with flow-labels).But that requires a larger refactoring of the
$wheresink, and could end up costing performance.With this solution there can be a disconnect between a query-call and the alert location.
But I don't see a good solution to this.