Sitelet https://web.archive.org/web/20201105000358/https://github.com/ethereum/eth-rlp/pull/9
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git checkout with http instead of ssh #9

Draft
wants to merge 1 commit into
base: master
from
Draft

Conversation

@carver
Copy link
Contributor

@carver carver commented Sep 1, 2020

What was wrong?

Master failing on CI, due to checkout issues. Maybe the SSH key that circle uses is not added to this project?

How was it fixed?

Check out with http instead of ssh.

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@carver carver force-pushed the carver:ci-fix branch 4 times, most recently from fb585b3 to 525860a Sep 1, 2020
@carver carver force-pushed the carver:ci-fix branch from 525860a to d8e84d4 Sep 1, 2020
@carver
Copy link
Contributor Author

@carver carver commented Sep 1, 2020

I mostly wanted to make sure that the only problem was checking out. That seems to be correct.

@carver
Copy link
Contributor Author

@carver carver commented Sep 1, 2020

Current plan is to hold off merging this, and eventually add the SSH key so that circleci can check out the repo its favorite way. Then we can just close this PR without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.