Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: update scss-bundle to avoid node-sass dependency #17978
Merged
Conversation
The `scss-bundle` package has a dependency on `node-sass` in the older versions. This makes our tooling reliant on native bindings, and requires additionally work in framework where we integrate our tooling into a different environment setup (e.g. different node version). Regardless of that though, it's generally better not relying on node-sass or native bindings since we use `sass` (not node-sass) for building with Bazel.
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "*1": "scss-bundle requires a config file in the Bazel execroot.", | |||
| "*2": "The config is used in the src/material:theming_bundle target", | |||
devversion
Dec 16, 2019
•
Author
Member
I don't like that scss-bundle now requires a config file since from a Bazel perspective.. it was more convenient to just pass flags & and sometimes needed for $(location).
Though there is no way around it for now. We can create an issue to ask them to make the config file optional.. but it looks like they need it for more (e.g. determining node modules folder)
I don't like that scss-bundle now requires a config file since from a Bazel perspective.. it was more convenient to just pass flags & and sometimes needed for $(location).
Though there is no way around it for now. We can create an issue to ask them to make the config file optional.. but it looks like they need it for more (e.g. determining node modules folder)
|
LGTM |
c734deb
into
angular:master
10 of 12 checks passed
10 of 12 checks passed
ci/angular: merge status
Status "ci/circleci: tests_saucelabs" is pending
cla/google
All necessary CLAs are signed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The
scss-bundlepackage has a dependency onnode-sassin the olderversions. This makes our tooling reliant on native bindings, and requires
additionally work in framework where we integrate our tooling into a different
environment setup (e.g. different node version).
Regardless of that though, it's generally better not relying on node-sass
or native bindings since we use
sass(not node-sass) for building with Bazel.Note: we still have an unused dependency on
node-sassthroughgulp-sass.. but that will be gone eventually.. and at the moment we don't usenode-sassat all (which is good)