Sitelet https://web.archive.org/web/20200902074930/https://github.com/ProAlgos/ProAlgos-Cpp/issues/99
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement data validation #99

Open
cosmopockets opened this issue Aug 21, 2017 · 12 comments · May be fixed by #341
Open

Implement data validation #99

cosmopockets opened this issue Aug 21, 2017 · 12 comments · May be fixed by #341
Assignees

Comments

@cosmopockets
Copy link

@cosmopockets cosmopockets commented Aug 21, 2017

Could we add some data validation functions such as,
make upper case,
make lower case,
get random double,
get random int?

@alxmjo alxmjo added the Utility label Aug 30, 2018
@alxmjo alxmjo added the Up for grabs label Sep 6, 2018
@mrKappen
Copy link

@mrKappen mrKappen commented Sep 27, 2018

I am on it!

@alxmjo
Copy link
Collaborator

@alxmjo alxmjo commented Sep 27, 2018

@mrKappen Great! Also, if you're new to the repo and want to get your feet wet, a great way to do that is to migrate an algorithm to the new organization scheme, à la #201 and #202. Let me know if you have any questions.

@alxmjo alxmjo removed the Up for grabs label Sep 27, 2018
mrKappen added a commit to mrKappen/Algos that referenced this issue Oct 2, 2018
mrKappen added a commit to mrKappen/Algos that referenced this issue Oct 2, 2018
@mrKappen mrKappen mentioned this issue Oct 2, 2018
0 of 2 tasks complete
@alxmjo
Copy link
Collaborator

@alxmjo alxmjo commented May 8, 2020

This also requires some thought as to what our goals would be regarding validation and how we would want to implement it in the project.

@alxmjo alxmjo added the Up for grabs label May 26, 2020
@alxmjo alxmjo changed the title Implementing Data Validation Implement data validation May 26, 2020
@beardbytes
Copy link

@beardbytes beardbytes commented May 28, 2020

I am interested and new to open source

@alxmjo
Copy link
Collaborator

@alxmjo alxmjo commented May 28, 2020

Great! Have a look at PR #209. A lot of the work is already done but it was closed automatically a while ago (there were merge issues that were never sorted out).

@beardbytes
Copy link

@beardbytes beardbytes commented May 29, 2020

Alright ! I can't find the file .

@alxmjo
Copy link
Collaborator

@alxmjo alxmjo commented May 29, 2020

@beardbytes
Copy link

@beardbytes beardbytes commented May 29, 2020

Alright ! I can't find the file .

Try this: https://github.com/ProAlgos/ProAlgos-Cpp/pull/209/commits#diff-264aaf8546723aaccf7ce2e80d46ae3f

Okay ! I am looking where the commit conflicts are present .

@alxmjo
Copy link
Collaborator

@alxmjo alxmjo commented May 29, 2020

Might be easiest to just add the file from scratch rather than trying to manage conflicts. I think the folder organization is good, though. include/utils/data_validation.hpp. I think it would be better to separate the random number generation into a different file. And of course we'll want to add unit tests for anything we add.

@beardbytes
Copy link

@beardbytes beardbytes commented May 29, 2020

Okay . So , just to be clear .
I have to make a new file in the include/utils directory . And I have to add data validation functions in this file along with unit tests !

@alxmjo
Copy link
Collaborator

@alxmjo alxmjo commented May 29, 2020

Yep!

  • Create a new file under include/utils called data_conversion.hpp (I think this title is a better reflection of the fact that we're converting cases of characters – we could add other data conversion functions later).
  • In that file add two functions: make_upper_case() and make_lower_case(). The random number generation can go in a different file later on.
  • Add unit tests for these functions under test/utils in a file called data_conversion.cpp.
  • If you're having trouble figuring out what the tests should look like, look at other testing files to get an idea how they work.

Let me know if you have any questions. 🙂

@beardbytes
Copy link

@beardbytes beardbytes commented May 29, 2020

Okay..Thanks for the explanation !

@alxmjo alxmjo linked a pull request that will close this issue May 30, 2020
2 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.