Sitelet https://web.archive.org/web/20260605013116/https://github.com/TheAlgorithms/Python/pull/2434
Skip to content

Corrected greedy_best_first#2434

Closed
badrinath-reddy wants to merge 1 commit into
TheAlgorithms:masterfrom
badrinath-reddy:master
Closed

Corrected greedy_best_first#2434
badrinath-reddy wants to merge 1 commit into
TheAlgorithms:masterfrom
badrinath-reddy:master

Conversation

@badrinath-reddy
Copy link
Copy Markdown

@badrinath-reddy badrinath-reddy commented Sep 16, 2020 •
edited
Loading

The algorithm was not best first search in the file greedy_best_first_search.py, It is A* algorithm, I have modified it.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@badrinath-reddy
Copy link
Copy Markdown
Author

badrinath-reddy commented Sep 16, 2020

https://stackoverflow.com/questions/34244452/whats-the-difference-between-best-first-search-and-a-search
Please consider seeing this explanation.

@stale
Copy link
Copy Markdown

stale Bot commented Oct 16, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Used to mark an issue or pull request stale. label Oct 16, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Oct 23, 2020

Please reopen this issue once you commit the changes requested or make improvements on the code. Thank you for your contributions.

@stale stale Bot closed this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

stale Used to mark an issue or pull request stale.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@badrinath-reddy @badrinath-newzera