Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove DiffList #1733
Merged
Remove DiffList #1733
Conversation
|
Thanks, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
igncp commentedOct 6, 2019
The
DiffListis a legacy name for a type that doesn't currently exist. In cases where several diffs are returned,Array<Diff>is documented.However, Tree#diff and Tree#diffWithOptions return a single
{Diff}, which is incorrect in the docs:This PR removes
DiffListfrom the repo to avoid confusion and updates to the correct type. Please see this previous issue for more context: #1359Thanks for the library👍