Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix behavior of Commit#parent #1509
Merged
Conversation
|
Ping @tbranyen, @johnhaley81, @maxkorp. |
|
@implausible Sorry for the late reply. Is the new commit better? |
|
Ping @implausible, it's been far more than a year, is this still a helpful PR? If not, please close it. |
Commit#parent did not assign the repo property so subsequent calls which relied on this property (such as Commit#getTree) failed. This change works around this problem by imitating what LookupWrapper does for Commit.lookup, that is, it wraps the actual call in a new function and manually assigns the repo property.
a84df76
to
e3bb744
cf10bce
into
nodegit:master
12 checks passed
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tniessen commentedJun 6, 2018
Commit#parentdid not assign therepoproperty so subsequent calls which relied on this property (such asCommit#getTree) failed. This change works around this problem by imitating whatLookupWrapperdoes forCommit.lookup, that is, it wraps the actual call in a new function and manually assigns therepoproperty.This commit also adds a test case for the corrected behavior.