Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unnecessary assignment of Commit#repo #1508
Conversation
|
Ping @tbranyen, @johnhaley81, @maxkorp. |
|
It's been far more than a year, please close this if you do not want to merge it. |
|
Tests aren't passing and the CI is failing. We can't merge it like this. Please correct the issues or ask for help and we can get this merged if it's still needed. |
|
@tbranyen If I remember correctly, the failures were due to problems on your side, not on mine, and CI last ran two years ago on this. But sure, I will rebase and force-push to cause a new CI run. |
Repository#getCommit uses Commit.lookup and then manually assigns to Commit#repo even though Commit.lookup already does that.
112317f
to
c2b61a2
|
My patch seems to be working fine, so it must have been problems with your existing code or your CI setup. |
|
Looks good |
tniessen commentedJun 6, 2018
Repository#getCommitusesCommit.lookupand then manually assigns toCommit#repoeven thoughCommit.lookupalready does that. There is no way forCommit.lookupto return aCommitwithout arepoproperty.