Sitelet https://web.archive.org/web/20200908014141/https://github.com/plotly/plotly.github.io/pull/488
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme docs in chart studio! #488

Open
wants to merge 6 commits into
base: master
from
Open

theme docs in chart studio! #488

wants to merge 6 commits into from

Conversation

@Mahdis-z
Copy link
Contributor

Mahdis-z commented May 13, 2019 •

closes #473

@Mahdis-z Mahdis-z requested a review from cldougl May 13, 2019
Copy link
Member

cldougl left a comment

Nice first draft @Mahdis-z ! I've added some suggestions


- title: Create a Theme
sub-steps:
- copy: "After you've plotted, styled your graph, and saved it, click on the 'Create' under the 'Theme' button on the left-hand side of chart studio. Then click on the 'Enable' button to make a theme from your current plot style.

This comment has been minimized.

@cldougl

cldougl May 13, 2019

Member

After you've plotted, styled your graph, and saved it,

After you've plotted, styled and saved your graph,

Then click on the 'Enable' button

Next, click on the 'Enable' button

This comment has been minimized.

@cldougl

cldougl May 13, 2019

Member

maybe here would be a good place to talk about what gets saved as part of the theme? Graph colors, background colors etc


- title: Theme vs. Template
sub-steps:
- copy: "Templates are the foundation of your work, that means you start with the pre-made templates, then add your own data and style it as you wish. While, you can apply a theme either after creating your graph from scratch, or from the beginning. You can add collaborators and give them 'Read & Write' or 'Read-only' permission. See ['add collaborators'](https://help.plot.ly/collaborate-in-plotly) for more information."

This comment has been minimized.

@cldougl

cldougl May 13, 2019

Member

should link to the template doc in here

This comment has been minimized.

@cldougl

cldougl May 13, 2019

Member

let's rework this section a little bit and provide specific information on when to use a template vs when to use a theme. The template will be more related to the data structure (ie the same traces will be plotted each time), where theme is more about the style attributes.

steps:
- title: Introduction
sub-steps:
- copy: "Make branding consistency much easier by creating your customize theme or use one of Plotly six built-in themes and share them with your team. Theming save your time, and makes it much easier to re-use your favorite defaults over again."

This comment has been minimized.

@cldougl

cldougl May 13, 2019

Member

I've corrected a few typos and I think this would be a bit easier to read as follows:

Make branding consistency much easier by creating a custom theme that you can share with your team, or use one of Plotly's six pre-built themes. Theming can save you time, and makes it much easier to re-use your favorite defaults.

@Mahdis-z Mahdis-z requested a review from cldougl May 14, 2019
Mahdis-z added 4 commits May 15, 2019
…nto theme2

update theme with deletion of a wrong file
@bpostlethwaite
Copy link
Member

bpostlethwaite commented Oct 3, 2019

What is the status of this PR, are we waiting for something?

@nicolaskruchten
Copy link
Member

nicolaskruchten commented Oct 3, 2019

We can revive it.

@nicolaskruchten nicolaskruchten removed the request for review from cldougl Oct 3, 2019
@nicolaskruchten
Copy link
Member

nicolaskruchten commented Oct 3, 2019

I'll take the ball on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.