C++: Fix performance in Iterator.qll#4203
Closed
rdmarsh2 wants to merge 1 commit intogithub:mainfrom
Closed
Conversation
8b2771c to
3752c46
Compare
jbj
reviewed
Sep 4, 2020
Contributor
jbj
left a comment
There was a problem hiding this comment.
If you prefer that we merge this PR more or less as is, please post the before-and-after performance numbers.
| exists(Expr arg | arg = op.getACallToThisFunction().getArgument(index) | | ||
| result = arg.getConversion*() and | ||
| (result = arg or not result.(Cast).isImplicit()) and | ||
| not exists(Cast other | other = result.getConversion+() and not other.isImplicit()) |
Contributor
There was a problem hiding this comment.
This would be more readable to me as a forall.
Contributor
|
Now that #4213 is merged, it's my understanding that this PR no longer provides large enough performance savings to make up for the added complexity. I'll close this, but please reopen if you think this change is still worth making. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.