Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Release v19.12.0 #1740
Release v19.12.0 #1740
Conversation
|
Just need to merge the changelog and version bump, then I'll cut the release |
Codecov Report
@@ Coverage Diff @@
## master #1740 +/- ##
=======================================
Coverage 92.18% 92.18%
=======================================
Files 22 22
Lines 2238 2238
Branches 419 419
=======================================
Hits 2063 2063
Misses 136 136
Partials 39 39
Continue to review full report at Codecov.
|
|
Just one comment about changing something in the pyproject.toml Another note: your commit says that it’s updating from 19.12 to 19.12, you might want to edit it to reflect what it’s actually doing. |
| @@ -1,6 +1,6 @@ | |||
| [tool.towncrier] | |||
| package = "sanic" | |||
| package_dir = "." | |||
| package_dir = ".." | |||
seemethere
Dec 27, 2019
Member
Was this change intentional? Not exactly versed on this particular file but didn’t really see a comment about it from the PR
Was this change intentional? Not exactly versed on this particular file but didn’t really see a comment about it from the PR
sjsadowski
Dec 27, 2019
Author
Contributor
it was, sorry. @harshanarayana 's 'make release' was looking for the sanic package in the scripts/ dir, not in the root of the project, and towncrier was failing to execute.
it was, sorry. @harshanarayana 's 'make release' was looking for the sanic package in the scripts/ dir, not in the root of the project, and towncrier was failing to execute.
|
|
@andreymal we're going to have to do some cleanup to get this one out the door anyway it looks like. I'll add that to the list. |
No description provided.