Sitelet https://web.archive.org/web/20200911092923/https://github.com/kubeflow/kubeflow/issues/3907
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a report of vulnerabilities for Kubeflow images #3907

Open
elviraux opened this issue Aug 15, 2019 · 16 comments
Open

Generate a report of vulnerabilities for Kubeflow images #3907

elviraux opened this issue Aug 15, 2019 · 16 comments

Comments

@elviraux
Copy link
Member

@elviraux elviraux commented Aug 15, 2019

Every kubeflow image should be scanned for security vulnerabilities.
It would be great to have a periodic security report.
Each of these images with vulnerability should be patched and updated.

@elviraux elviraux created this issue from a note in 0.7.0 (To Do) Aug 15, 2019
@issue-label-bot
Copy link

@issue-label-bot issue-label-bot bot commented Aug 15, 2019

Issue-Label Bot is automatically applying the label improvement/enhancement to this issue, with a confidence of 0.88. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@elviraux
Copy link
Member Author

@elviraux elviraux commented Aug 15, 2019

/area manifests
/priority p1

@jlewi jlewi added this to To Do in Needs Triage Aug 19, 2019
@jlewi
Copy link
Contributor

@jlewi jlewi commented Aug 19, 2019 •

Is this a duplicate of kubeflow/testing#421

@jlewi jlewi added this to To do in engprod via automation Aug 26, 2019
@jlewi jlewi added this to To do in KF1.0 via automation Aug 26, 2019
@jlewi jlewi added the area/engprod label Aug 26, 2019
@jlewi jlewi removed this from To Do in 0.7.0 Aug 26, 2019
@jlewi jlewi changed the title Sanitize images used by kubeflow Generate a report of vulnerabilities for Kubeflow images Aug 26, 2019
@jlewi jlewi added the help wanted label Aug 26, 2019
@jlewi
Copy link
Contributor

@jlewi jlewi commented Aug 26, 2019

Vulnerability scanning is turned on in our GCR repositories.

I think the next step would be to generate a report with a list of all the vulnerabilities for different images.

I imagine the list of vulnerabilities can be fetched via GCP API from the GCR repository (tutorial).

We probably don't want to look at all images in the registry but instead look through the applications based on kubeflow/manifests; identify the images for different applications and generate a list of vulnerabilities for those docker images.

To start I would suggest focusing on the applications that are in scope for 1.0.

List of applications in scope for 1.0.

It would be great to look at the associated images and open up issues for any ones that have vulnerabilities that need to be fixed.

@elviraux is this something you could help with?

@jlewi jlewi removed this from To Do in Needs Triage Sep 9, 2019
@elviraux
Copy link
Member Author

@elviraux elviraux commented Sep 11, 2019

@jlewi 👍🏻

@jlewi
Copy link
Contributor

@jlewi jlewi commented Sep 15, 2019

It looks like GCR will automatically show a list of vulnerabilities a long with the severity and whether there are fixes available. This is available just by going to the publicly accessible link.

http://gcr.io/kubeflow-images-public/tensorflow-1.13.1-notebook-gpu

Here's a screenshot
vulnerabilities

This means for any images we build users can get a report just by going to the GCR link for the image.

This wouldn't apply to images that we pull from other repositories like DockerHub/Quay (e.g. for Argo etc...).

For 1.0 this seems reasonable to me because we are covering only the applications specifically built and maintained by the Kubeflow community.

@jbottum @elviraux Does this seem sufficient to you?

@nrchakradhar
Copy link
Contributor

@nrchakradhar nrchakradhar commented Sep 15, 2019

Do we need some privileges to see the vulnerabilities?
I clicked the link and selected the first image but only get the following. No link to vulnerabilities.
Screenshot

@jlewi
Copy link
Contributor

@jlewi jlewi commented Sep 16, 2019

@nrchakradhar Looks like you are right; the vulnerabilities aren't publicly visible. So we'll probably need to write some script to fetch them via API and publish them as a markdown doc.

@swiftdiaries
Copy link
Member

@swiftdiaries swiftdiaries commented Dec 1, 2019

Started work on a CLI tool to fetch them via API:
https://github.com/CiscoAI/kubeflow-scanner
I'll update progress and if enough people need this we can include it in CI

@jlewi
Copy link
Contributor

@jlewi jlewi commented Dec 16, 2019

@swiftdiaries any update?

@swiftdiaries
Copy link
Member

@swiftdiaries swiftdiaries commented Jan 7, 2020

I'm trying to setup a static site that would show vulnerabilities with the images. I hope to get it done by the end of the week.

@jlewi
Copy link
Contributor

@jlewi jlewi commented Jan 23, 2020

@swiftdiaries did you consider just checking in HTML or other output into GitHub?

@stale
Copy link

@stale stale bot commented Apr 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Apr 22, 2020
@stale stale bot closed this Apr 29, 2020
engprod automation moved this from To do to Done Apr 29, 2020
KF1.0 automation moved this from To do to Done Apr 29, 2020
@jlewi jlewi reopened this May 29, 2020
engprod automation moved this from Done to In progress May 29, 2020
KF1.0 automation moved this from Done to In progress May 29, 2020
@stale stale bot removed the lifecycle/stale label May 29, 2020
@jlewi
Copy link
Contributor

@jlewi jlewi commented May 29, 2020

/lifecycle frozen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
engprod
  
In progress
KF1.0
  
In progress
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.