Sitelet https://web.archive.org/web/20200907053432/https://github.com/Kong/kong/issues/6051
Skip to content

/ kong

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS OPTIONS(Preflight request) request should return 204 #6051

Open
dzmitry-lahoda opened this issue Jun 24, 2020 · 0 comments · May be fixed by #6208
Open

CORS OPTIONS(Preflight request) request should return 204 #6051

dzmitry-lahoda opened this issue Jun 24, 2020 · 0 comments · May be fixed by #6208
Labels
good first issue task/feature

Comments

@dzmitry-lahoda
Copy link

@dzmitry-lahoda dzmitry-lahoda commented Jun 24, 2020

Next line returns 200 as status

kong/kong/plugins/cors/handler.lua

Line 13 in c817fad

local HTTP_OK = 200

Internet says it should return 204:

Internet changed its mind since 2018 #4029
@thehanimo thehanimo mentioned this issue Aug 11, 2020
Closed
thehanimo added a commit to thehanimo/kong that referenced this issue Aug 11, 2020
@thehanimo
fix(cors) send HTTP 204 on Preflight request
9c175d6 
The appropriate status code for a preflight request is 204 as per the updated Mozilla guidelines (https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request). We previously used to send HTTP 200.

* return 204 for preflight response instead of 200

Fix Kong#6051
@thehanimo thehanimo linked a pull request that will close this issue Aug 11, 2020
Open
@devinivy devinivy mentioned this issue Aug 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue task/feature
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix(cors) send HTTP 204 on Preflight request
fix(cors) send HTTP 204 on Preflight request
2 participants
@dzmitry-lahoda @gszr
You can’t perform that action at this time.