Sitelet https://web.archive.org/web/20200905030044/https://github.com/apache/shardingsphere/issues/7000
Skip to content

/ shardingsphere

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish OrchestrationBootstrapTest‘s assertion #7000

Open
terrymanu opened this issue Aug 22, 2020 · 6 comments
Open

Finish OrchestrationBootstrapTest‘s assertion #7000

terrymanu opened this issue Aug 22, 2020 · 6 comments
Assignees
@jian365066744
Labels
good first issue test
Milestone
5.0.0-alpha

Comments

@terrymanu
Copy link
Member

@terrymanu terrymanu commented Aug 22, 2020

Please finish assertProxyConfiguration for two test cases
@terrymanu terrymanu added this to the 5.0.0-alpha milestone Aug 22, 2020
@jian365066744
Copy link
Contributor

@jian365066744 jian365066744 commented Aug 22, 2020

assign to me
@terrymanu terrymanu mentioned this issue Aug 24, 2020
Closed
jian365066744 added a commit to jian365066744/shardingsphere that referenced this issue Aug 24, 2020
@jian365066744
Finish OrchestrationBootstrapTest‘s assertion apache#7000
7728809
@jian365066744 jian365066744 mentioned this issue Aug 24, 2020
Closed
jian365066744 added a commit to jian365066744/shardingsphere that referenced this issue Aug 24, 2020
@jian365066744
Finish OrchestrationBootstrapTest‘s assertion apache#7000
405496f
jian365066744 added a commit to jian365066744/shardingsphere that referenced this issue Aug 24, 2020
@jian365066744
Finish OrchestrationBootstrapTest‘s assertion apache#7000
48aebec
@jian365066744
Copy link
Contributor

@jian365066744 jian365066744 commented Aug 25, 2020

why didn't merge?can you give me tips?
@terrymanu
Copy link
Member Author

@terrymanu terrymanu commented Aug 30, 2020

@jian365066744 I post code review comment on your pull request, please check and fix them
jian365066744 added a commit to jian365066744/shardingsphere that referenced this issue Aug 30, 2020
@jian365066744
Finish OrchestrationBootstrapTest‘s assertion apache#7000
0f1590c
@jian365066744
Copy link
Contributor

@jian365066744 jian365066744 commented Aug 30, 2020

I have add more assert,is all right?
image
@jian365066744
Copy link
Contributor

@jian365066744 jian365066744 commented Aug 30, 2020

if the #7000 is correct , please merge to master,or you can tell the details reason as soon as possible.so I can fix and finish the #6926
jian365066744 added a commit to jian365066744/shardingsphere that referenced this issue Aug 31, 2020
@jian365066744
Finish OrchestrationBootstrapTest‘s assertion apache#7000
26df3b6 
recover before
terrymanu pushed a commit that referenced this issue Aug 31, 2020
@jian365066744
Add more assertions of MasterSlaveSpringBootStarterTest #6926 (#7168)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4e0e6cb 
* Add more assertions of MasterSlaveSpringBootStarterTest #6926

* Finish OrchestrationBootstrapTest‘s assertion #7000
recover before

* Add more assertions of MasterSlaveSpringBootStarterTest  #6926
@jian365066744
Copy link
Contributor

@jian365066744 jian365066744 commented Sep 1, 2020

Do you delete the OrchestrationBootstrapTest ? I can't find the class in latest version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jian365066744 jian365066744

Labels
good first issue test
Projects
None yet
Milestone
5.0.0-alpha
Linked pull requests

Successfully merging a pull request may close this issue.

Finish assertProxyConfiguration for two test cases
2 participants
@terrymanu @jian365066744
You can’t perform that action at this time.