Sitelet https://web.archive.org/web/20200905065418/https://github.com/phpstan/vim-phpstan/pull/3
Skip to content

/ vim-phpstan

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimscript implementation #3

Open
wants to merge 3 commits into
base: master
from
Open

Vimscript implementation #3

wants to merge 3 commits into from

Conversation

@dantleech
Copy link

dantleech commented Mar 31, 2018 •
edited

Hey :)

This PR:

  • Adjusts the plugin to use only Vimscript, taking advantage of the --errorFormat=raw option.
  • Tries to detect project versions of PHPStan, falling back to the global executable.

Todo:

  • Add some documentation.
  • Test it properly
  • Include phpstan.neon if it exists...

Initially this plugin didn't work because I didn't have phpstan installed globally, then I just thought I'd try and adopt the VIMScript approach.
dantleech added 2 commits Mar 31, 2018
@dantleech
Refactored to use VIMScript
e7f9338
@dantleech
Configure phpstan paths
979a961
@dantleech dantleech force-pushed the dantleech:vimscript branch 2 times, most recently from 955f64d to e46246a Mar 31, 2018
@dantleech
Do not trunacte description
2b0eb47
@dantleech dantleech force-pushed the dantleech:vimscript branch from e46246a to 2b0eb47 Mar 31, 2018
@akrabat
Copy link

akrabat commented Sep 14, 2018 •
edited

This worked for me as I have PHPStan installed in vendor/bin/phpstan

Thanks!
@mstyles
Copy link

mstyles commented Oct 23, 2018

This sounds like a great addition, as I also have PHPStan installed at the project level. Any reason why this hasn't been merged?
@dantleech
Copy link
Author

dantleech commented Oct 24, 2018 •
edited

For what it's worth, I switched to using Ale which supports Phpstan OOTB: https://github.com/w0rp/ale (works best with phpstan installed globally)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@dantleech @akrabat @mstyles
You can’t perform that action at this time.