Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAssertion Refactoring: Use DSL and allow assertions on baseline #656
Conversation
| @@ -110,7 +112,7 @@ public function testLogError() | |||
| { | |||
| $this->variant->hasErrorStack()->willReturn(true); | |||
| $this->variant->getSubject()->willReturn($this->subject->reveal()); | |||
| $this->variant->hasFailed()->willReturn(false); | |||
| $this->variant->getAssertionResults()->willReturn(new VariantAssertionResults($this->variant->reveal(), [])); | |||
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dantleech commentedAug 28, 2020
•
edited
This PR refactores the assertion feature:
@Assert("variant.mean < 100 microseconds +/- 10 microseconds")@Assert("variant.mode < baseline.mode +/- 10 milliseconds")The DSL is using the Parsica library which requires PHP 7.4 - need to decide if we bump the whole library to 7.4 or backport some or all of Parsica to 7.2/7.3.
Features:
@Assert("variant.mode within 10% +/- 5% of baseline.mode)#phpbench run benchmarks/MyBench.php --assert="variant.mode < 5 microseconds"TODO:
microseconds=>μs,+/-=>±)@Assert("variant.mode throughput > 100 rps) ??)%cases (e.g. working with tolerance)WITHINoperator