Sitelet https://web.archive.org/web/20210111231506/https://github.com/akveo/ngx-admin/pull/5727

akveo / ngx-admin

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to angular v10 #5727

Open

nhaancs wants to merge 7 commits into akveo:master from unknown repository

nhaancs commented Jul 14, 2020

Please read and mark the following check list before creating a pull request (check one with "x"):

I read and followed the CONTRIBUTING.md guide.
I read and followed the New Feature Checklist guide.

Short description of what this resolves:

Nhan NQ added 7 commits


          - first build

00fdf04


          - update version ng2-ckeditor, @angular-devkit/build-angular

121767f


          - update from angular from version 9 to 10

2743de7


          - fix deprecated propertiy

a143611


          - update rxjs

9e4aa45


          - update @swimlane/ngx-charts

0ccfb9d


          - update @angular/cdk to v10

168ea7f

jainAdijain reviewed

  
            "intl": "1.2.5",

            "ionicons": "2.0.1",

            "leaflet": "1.2.0",

            "nebular-icons": "1.1.0",

            "ng2-ckeditor": "^1.2.2",

            "ng2-ckeditor": "^1.2.7",

jainAdijain Jul 17, 2020

Should we update the this package when migrating it to next stable version ?
Curious to know if it wont affect the working ?

nhaancs Jul 20, 2020
Author

The current version has incompatible dependency so I upgraded it

jainAdijain commented Jul 17, 2020

Cursious, to know did you followed any process to migrate it to next stable version of Angular?
If you can share any pointers ?

Thanks,
Aditya

Author

nhaancs commented Jul 20, 2020

Hey @nhaancs ,

Cursious, to know did you followed any process to migrate it to next stable version of Angular?
If you can share any pointers ?

Thanks,
Aditya

I followed the guidelines from https://update.angular.io. Some packages have incompatible dependencies and I updated them too.

jainAdijain approved these changes

jainAdijain left a comment

Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.