Sitelet https://web.archive.org/web/20250114191740/https://github.com/espressif/esp-idf/pull/5794
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows incompatibility with gdbgui>=0.14 (IDFGH-3896) #5794

Closed
wants to merge 1 commit into from
Closed

fix windows incompatibility with gdbgui>=0.14 (IDFGH-3896) #5794

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2020

gdbgui intentionally (cs01/gdbgui#346) introduced dependencies that are incompatible with windows, and don't seem to have plans to resolve them anytime soon

gdbgui intentionally (cs01/gdbgui#346) introduced dependencies that are incompatible with windows, and don't seem to have plans to resolve them anytime soon
@CLAassistant
Copy link

CLAassistant commented Aug 26, 2020 •

CLA assistant check
All committers have signed the CLA.

@ghost
Copy link
Author

ghost commented Aug 26, 2020

fixes #5787

@github-actions github-actions bot changed the title fix windows incompatibility with gdbgui>=0.14 fix windows incompatibility with gdbgui>=0.14 (IDFGH-3896) Aug 26, 2020
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue! The changes are pending the internal review/test pipeline and will be merged (We might possibly be more strict and enforce the 0.13.2.0 version only)

@david-cermak
Copy link
Collaborator

@istokm Thank you for your help, Linking also #5782

@v1993
Copy link
Contributor

v1993 commented Aug 26, 2020

Relevant gdgbui issue: cs01/gdbgui#348

Note that it is not true that they have no plans to resolve it at all, just not right now:

Screenshot_20200826_231507

It also wasn't done "intentionally" as to make windows unusable, only because new UI is much better and happens not to work properly on windows.

Related question: would it be possible for users on other platforms to use new version? If API is the same it would be great to take advantage of updated UI on Linux (and OS X?).

@@ -11,7 +11,7 @@ future>=0.15.2
cryptography>=2.1.4
pyparsing>=2.0.3,<2.4.0
pyelftools>=0.22
gdbgui>=0.13.2.0
gdbgui<=0.13.2.1,>=0.13.2.0
pygdbmi<=0.9.0.2
Copy link

@cs01 cs01 Aug 29, 2020 •

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gdbgui calls out which pygdbmi version it requires, so it shouldn't be included here.

This project might consider using pip-tools, which lets you specify things that should be installed at the top level, and then generates a requirements.txt lock file:

# requirements.in 
gdbgui==0.13.2.0

then compile the top level requirements into a lock file:

> pip-compile 
#
# This file is autogenerated by pip-compile
# To update, run:
#
#    pip-compile
#
brotli==1.0.9             # via flask-compress
click==7.1.2              # via flask
dnspython==2.0.0          # via eventlet
eventlet==0.25.2          # via gdbgui
flask-compress==1.5.0     # via gdbgui
flask-socketio==2.9.6     # via gdbgui
flask==0.12.5             # via flask-compress, flask-socketio, gdbgui
gdbgui==0.14.0.0          # via -r requirements.in
gevent-websocket==0.10.1  # via gdbgui
gevent==1.5.0             # via gdbgui, gevent-websocket
greenlet==0.4.16          # via eventlet, gevent
itsdangerous==1.1.0       # via flask
jinja2==2.11.2            # via flask
markupsafe==1.1.1         # via jinja2
monotonic==1.5            # via eventlet
pygdbmi==0.10.0.0         # via gdbgui
pygments==2.6.1           # via gdbgui
python-engineio==3.13.2   # via python-socketio
python-socketio==4.6.0    # via flask-socketio
six==1.15.0               # via eventlet, python-socketio
werkzeug==0.16.1          # via flask

It also includes a dependency resolver, which ensures there are no conflicting requirements in the installed versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cs01, pygdbmi is also a "top-level" requirement in ESP-IDF, this is why it is mentioned here explicitly. Thanks for the pointer about pip-tools, it looks very useful!

@cs01
Copy link

cs01 commented Aug 29, 2020

Hi I came across this from the gdbgui issue (I am the creator/maintainer). I am hoping to get windows support added back someday with https://bugs.python.org/issue41663. Until then, I wonder if there is a way to install the latest version of gdbgui for non-windows users, and use a frozen version for windows users. As @v1993 mentioned, the new UI offers a better experience for users.

espressif-bot pushed a commit that referenced this pull request Sep 16, 2020
gdbgui intentionally (cs01/gdbgui#346) introduced dependencies that are incompatible with windows, and don't seem to have plans to resolve them anytime soon

Closes #5782
Closes #5787
Merges #5794
@Alvin1Zhang
Copy link
Collaborator

Alvin1Zhang commented Sep 17, 2020 •

Thanks for your contribution, changes merged by 96cfdf3.

espressif-bot pushed a commit that referenced this pull request Sep 22, 2020
gdbgui intentionally (cs01/gdbgui#346) introduced dependencies that are incompatible with windows, and don't seem to have plans to resolve them anytime soon

Closes #5782
Closes #5787
Merges #5794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants