Sitelet https://web.archive.org/web/20201107113902/https://github.com/benbusby/whoogle-search/pull/118
Skip to content

/ whoogle-search

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pipx run command #118

Merged
merged 1 commit into from Aug 20, 2020
Merged

fix pipx run command #118

merged 1 commit into from Aug 20, 2020

Conversation

@cs01
Copy link
Contributor

@cs01 cs01 commented Aug 20, 2020

Add the required --spec argument
@cs01
fix pipx run command
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
3264c48 
Add the required `--spec` argument
@benbusby
Copy link
Owner

@benbusby benbusby commented Aug 20, 2020

Is this a new requirement? When I was testing this originally the --spec argument wasn't required, although it's been a while since I originally wrote the documentation.

Either way, looks good to me.
@benbusby benbusby self-requested a review Aug 20, 2020
@benbusby
benbusby approved these changes Aug 20, 2020
View changes
@benbusby benbusby merged commit 6ba5e8f into benbusby:develop Aug 20, 2020
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
codebeat no reportable quality changes
Details
@cs01 cs01 deleted the cs01:patch-1 branch Aug 20, 2020
@cs01
Copy link
Contributor Author

@cs01 cs01 commented Aug 20, 2020

If the package name matches the app name (like youtube-dl, for example), the --spec argument is not needed. AFAIK this has always been the case.
@benbusby benbusby mentioned this pull request Oct 4, 2020
Merged
benbusby added a commit that referenced this pull request Oct 4, 2020
@benbusby
Release v0.2.1 (#116)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a8914e4 
- Updated dark theme (#121)
  - Dark theme is no longer the previous high contrast "white on black" color scheme
- New configuration settings
  - Split interface and result language config (#89)
  - Added option for using privacy respecting result alternatives (#106)
    - `youtube.com` -> `invidiou.site`
    - `twitter.com` -> `nitter.net`
    - `instagram.com` -> `bibliogram.art`
- Improved search suggestion arrow key navigation behavior (#115)
- Added repl.it deployment (#114)
- Improved ad filtering for non-English results (f7380ae)
- Split interface and result language config (#89)
- New config option: privacy respecting result alternatives (#106)
- Updated search suggestion behavior (#115)
- Minor project improvements and refactoring:
  - Added footer to results UI
  - Updated opensearch template
- Various bug fixes, including:
  - Fixed pipx run command (#118)
  - Fixed browser autocomplete (#128)
  - Fixed missing autofocus on search field in Firefox (dfb1e81)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbusby benbusby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cs01 @benbusby
You can’t perform that action at this time.