Sitelet https://web.archive.org/web/20200901060955im_/https://github.com/TheAlgorithms/Python/pull/2346
Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SettingWithCopy warning by pandas #2346

Merged
merged 7 commits into from Aug 23, 2020
Merged

Fix SettingWithCopy warning by pandas #2346

merged 7 commits into from Aug 23, 2020
+2 −15

Conversation

@zhqu1148980644
Copy link
Contributor

zhqu1148980644 commented Aug 22, 2020 •
edited

#2282

Describe your change:

#2282

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@zhqu1148980644
Fix SettingWithCopy warning in pandas
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
20263c9 
#2282
@zhqu1148980644 zhqu1148980644 changed the title Fix SettingWithCopy warning in pandas Fix SettingWithCopy warning by pandas Aug 22, 2020
@zhqu1148980644
Update k_means_clust.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4ea04fc
@zhqu1148980644
Update k_means_clust.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
323bd66
@zhqu1148980644
Update k_means_clust.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
643df8f
@TravisBuddy
Copy link

TravisBuddy commented Aug 23, 2020

Hey @zhqu1148980644,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 05229300-e514-11ea-862b-338b6fa79dcf
@zhqu1148980644
Update k_means_clust.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
c041ab7
@zhqu1148980644
Update k_means_clust.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
e30a203
@TravisBuddy
Copy link

TravisBuddy commented Aug 23, 2020

Hey @zhqu1148980644,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: cc9986c0-e51c-11ea-862b-338b6fa79dcf
@TravisBuddy
Copy link

TravisBuddy commented Aug 23, 2020

Hey @zhqu1148980644,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 03137300-e51d-11ea-862b-338b6fa79dcf
@zhqu1148980644
Update k_means_clust.py
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d68ed79
@cclauss
cclauss approved these changes Aug 23, 2020
View changes
@cclauss cclauss merged commit d402cd0 into TheAlgorithms:master Aug 23, 2020
2 checks passed
2 checks passed
codespell
Details
Travis CI - Pull Request Build Passed
Details
@cclauss
Copy link
Member

cclauss commented Aug 23, 2020

Thanks for doing this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss

Assignees
No one assigned
Labels
Need Reviews
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@zhqu1148980644 @TravisBuddy @cclauss
You can’t perform that action at this time.