Sitelet https://web.archive.org/web/20200901020708/https://github.com/hoppscotch/hoppscotch/issues/1003
Skip to content

/ hoppscotch

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS Home Bar covers content #1003

Open
NBTX opened this issue Jul 18, 2020 · 4 comments
Open

iOS Home Bar covers content #1003

NBTX opened this issue Jul 18, 2020 · 4 comments
Assignees
@abhijeet-pathak
Labels
bug good first issue minor
Projects
v2.0
Milestone
v2.0

Comments

@NBTX
Copy link
Member

@NBTX NBTX commented Jul 18, 2020

Describe the bug
Currently on iOS the app content is partially obscured by the bar at the bottom of the screen used for gesture based navigation (known as the ‘Home Bar’).

77F12CE4-893C-44A3-A8AF-98C8918333E7

To Reproduce
Open the Postwoman PWA on a modern iOS device without a physical home button.

Expected behavior
Padding should be applied such that the home bar does not obscure the app.

Additional context

  • Note(1): I have not included information about the specific browser or device as nearly all iOS devices run iOS 13 and all browsers on iOS installed through the App Store must use WebKit.
  • Note(2): Information on the iOS SafeArea (the area of the screen that is not obscured or the padding that needs to be applied such that content is not obscured) is provided by Apple via their WebKit blog: https://webkit.org/blog/7929/designing-websites-for-iphone-x/
@NBTX NBTX added this to the v2.0 milestone Jul 18, 2020
@NBTX NBTX added this to To do in v2.0 via automation Jul 18, 2020
@abhijeet-pathak
Copy link

@abhijeet-pathak abhijeet-pathak commented Jul 23, 2020

I would like to take this up.
@liyasthomas
Copy link
Member

@liyasthomas liyasthomas commented Jul 23, 2020

Great! Assigning this to you.
@AndrewBastin
Copy link
Member

@AndrewBastin AndrewBastin commented Aug 4, 2020

@abhijeet-pathak how's it going ?
@liyasthomas liyasthomas added the minor label Aug 20, 2020
liyasthomas added a commit that referenced this issue Aug 27, 2020
@liyasthomas
Respect safe areas in iOS - fix #1003
Loading status checks…
ed88037
@liyasthomas
Copy link
Member

@liyasthomas liyasthomas commented Aug 27, 2020

@NBTX let me know if this deploy preview fixes the issue.
Deploy preview: https://hoppscotch-8rc2a54tx.vercel.app/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhijeet-pathak abhijeet-pathak

Labels
bug good first issue minor
Projects
v2.0
  
To do
Milestone
v2.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@AndrewBastin @liyasthomas @NBTX @abhijeet-pathak
You can’t perform that action at this time.