Sitelet https://web.archive.org/web/20200816151911/https://github.com/google/go-github/pull/1597
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content_reference event #1597

Open
wants to merge 6 commits into
base: master
from

Conversation

@martin308
Copy link

martin308 commented Aug 13, 2020

Adds the content_reference web hook event along with the content reference type.

github/apps.go seemed the best place for ContentReference to live but if there is a better place let me know.

GitHub API docs: https://developer.github.com/webhooks/event-payloads/#content_reference

@google-cla
Copy link

google-cla bot commented Aug 13, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 13, 2020
@martin308
Copy link
Author

martin308 commented Aug 13, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 13, 2020
@codecov
Copy link

codecov bot commented Aug 13, 2020 •

Codecov Report

Merging #1597 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1597   +/-   ##
=======================================
  Coverage   67.98%   67.99%           
=======================================
  Files          96       96           
  Lines        8772     8774    +2     
=======================================
+ Hits         5964     5966    +2     
  Misses       1898     1898           
  Partials      910      910           
Impacted Files Coverage Δ
github/apps.go 62.50% <ø> (ø)
github/event_types.go 100.00% <ø> (ø)
github/messages.go 81.17% <ø> (ø)
github/event.go 94.11% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e19d4dd...c2eaef0. Read the comment docs.

@martin308
Copy link
Author

martin308 commented Aug 13, 2020

I don't really see any existing tests for this code path. Does that sound right?

@martin308
Copy link
Author

martin308 commented Aug 13, 2020

Found the ParseWebHook tests, added!

martin308 added 2 commits Aug 13, 2020
Copy link
Collaborator

gmlewis left a comment

Thank you, @martin308 !
Apart from the minor tweak for the godocs, this LGTM.

Awaiting second LGTM before merging.

github/apps.go Outdated Show resolved Hide resolved
@gmlewis gmlewis requested a review from wesleimp Aug 14, 2020
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
@martin308
Copy link
Author

martin308 commented Aug 14, 2020

@gmlewis great thanks! Found another issue implementing this content reference flow which is fixed in #1602

@martin308 martin308 requested a review from gmlewis Aug 14, 2020
Copy link
Collaborator

gmlewis left a comment

Thank you, @martin308 !
LGTM.

Awaiting second LGTM before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.