Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd content_reference event #1597
Conversation
google-cla
bot
commented
Aug 13, 2020
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
@googlebot I signed it! |
codecov
bot
commented
Aug 13, 2020
•
Codecov Report
@@ Coverage Diff @@
## master #1597 +/- ##
=======================================
Coverage 67.98% 67.99%
=======================================
Files 96 96
Lines 8772 8774 +2
=======================================
+ Hits 5964 5966 +2
Misses 1898 1898
Partials 910 910
Continue to review full report at Codecov.
|
|
I don't really see any existing tests for this code path. Does that sound right? |
|
Found the ParseWebHook tests, added! |
|
Thank you, @martin308 ! Awaiting second LGTM before merging. |
Co-authored-by: Glenn Lewis <6598971+gmlewis@users.noreply.github.com>
|
Thank you, @martin308 ! Awaiting second LGTM before merging. |
martin308 commentedAug 13, 2020
Adds the content_reference web hook event along with the content reference type.
github/apps.goseemed the best place forContentReferenceto live but if there is a better place let me know.GitHub API docs: https://developer.github.com/webhooks/event-payloads/#content_reference