Sitelet https://web.archive.org/web/20200814041122/https://github.com/nodejs/nodejs.dev/pull/824
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated header to improve positioning and accessibility #824

Open
wants to merge 1 commit into
base: master
from

Conversation

@marcustisater
Copy link

marcustisater commented Aug 11, 2020 •

Description

These changes is a collection of small adjustments, improves responsive design and accessibility for the header component.

Related Issues

  • Adds more padding for toggle dark mode button element. This will add the same clickable area for the user as main navigation and GitHub links currently have.
  • Fixes padding to make the entire nodejs logo clickable.
  • Restructured markup and CSS to make it easier when adding more elements, e.x searchbar.
  • Removed set widths so we don't need to add adjust CSS when adding more links.
  • Removed duplicated CSS selectors, merged into one.
  • Adds same padding for left and right side of the header.
  • Decreased GitHub link to make it fit in mobile.
  • Removed the set height for the header that caused wired offset. The header still have the same height.

Let me know what you think and if I should remove or add anything to these changes.

✌️

@marcustisater
Copy link
Author

marcustisater commented Aug 11, 2020 •

Mobile

mobile

Tablet / iPad

tablet

Desktop

desktop

@benhalverson
Copy link
Contributor

benhalverson commented Aug 11, 2020

/preview

@github-actions
Copy link

github-actions bot commented Aug 11, 2020

Please find a preview at: https://staging.nodejs.dev/824/

@marcustisater marcustisater force-pushed the marcustisater:master branch from d7b5175 to 22bb3ea Aug 11, 2020
@marcustisater marcustisater force-pushed the marcustisater:master branch from 22bb3ea to 6e9747a Aug 11, 2020
@marcustisater
Copy link
Author

marcustisater commented Aug 11, 2020

Thanks for the review. Commits are squashed into one and should be updated with master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.