Sitelet https://web.archive.org/web/20200917220530/https://github.com/nodejs/docker-node/issues/1225
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a tag for minimal supported version. #1225

Open
gengjiawen opened this issue Mar 2, 2020 · 11 comments
Open

create a tag for minimal supported version. #1225

gengjiawen opened this issue Mar 2, 2020 · 11 comments

Comments

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Mar 2, 2020

This will help lib authors to keep compatibility check without to change version after a version deprecated.

@nschonni
Copy link
Member

@nschonni nschonni commented Mar 2, 2020

I'm not sure I understand what you're asking for, can you try explaining it further? EX: there are tags for things like LTS and their code names https://registry.hub.docker.com/_/node/

@gengjiawen
Copy link
Member Author

@gengjiawen gengjiawen commented Mar 3, 2020

I want a tag for lowest supported Node.js version. Current is 10. like node: minimal point to it.

@DRoet
Copy link

@DRoet DRoet commented Mar 5, 2020

so basically the opposite of latest, seems like a valid use case

@LaurentGoderre
Copy link
Contributor

@LaurentGoderre LaurentGoderre commented Mar 5, 2020

I am hesitant to introduce a tag that isn't standard in either docker or nodejs. We tag based on what the core node project uses.

@nschonni
Copy link
Member

@nschonni nschonni commented Mar 5, 2020

I believe there has been some discussions on the general support strategy about versions and how to achieve it over in https://github.com/nodejs/package-maintenance
I'm also 👎 to adding this as a tag though.

@LaurentGoderre
Copy link
Contributor

@LaurentGoderre LaurentGoderre commented Mar 6, 2020

@rvagg is this something the core Node project ever consider using?

@rvagg
Copy link
Member

@rvagg rvagg commented Mar 9, 2020

The only way I can think of to consume such a tag would be with travis or github actions, but I don't think pushing that via docker is going to help much. It's really something you'd want nvm to support. 🤷‍♂

@soletan
Copy link

@soletan soletan commented Apr 9, 2020

I am hesitant to introduce a tag that isn't standard in either docker or nodejs. We tag based on what the core node project uses.

I don't see this argument. dubnium is quite as useless for most users and still it is applied. 10 is available either, currently. lts is used as is current or lts with neither of the two being usually available in docker repositories. And I don't see why offering a whole set of basically outdated major releases of Node.js at all when there is no reason for providing some useful tag to address this major release in opposition to the upcoming one and the LTS one.

In my case (#1240) I'm implementing several software packages each relying on CI for testing either package against latest, current or lts and whatever is available in addition without ever having to change the CI configuration whenever Node.js is switching from one major to another. I think as long as there are images provided for "old stable" there should be an opportunity for CIs to test against those packages as easy as possible as well. That's why I don't think minimal is a desirable candidate as it is suggesting use of outdated major version to be considered sufficient. Instead, I suggest using old.

@LaurentGoderre
Copy link
Contributor

@LaurentGoderre LaurentGoderre commented Apr 13, 2020

It's not hard to add but I don't want add semantic problems. For example old could be confused as EOL so the name of the tag is somewhat important.

@soletan
Copy link

@soletan soletan commented Apr 14, 2020

So, what about previous to accompany current, though previous-lts would be a better fit?

@gengjiawen
Copy link
Member Author

@gengjiawen gengjiawen commented Apr 14, 2020

I think this is a valid use case. tag changes all over the time. like latest, I think user can expect this. Only number are accurate in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.