/preview

Please find a preview at: https://staging.nodejs.dev/837/

hmmm...worked locally. don't see it

@benhalverson how do I see the built task to see what happened? or have any thoughts on why it's not showing?

@micahgodbolt because this change is coming from a fork the action will not run your modified code (this is a security feature)

oh yeah...been there done that!

if you create a branch in the repo i can target that instead, we can merge it into the branch and create PR into master

added typography

and colors page

want to break colors up a bit better and see if I can not rely on duplicated js object

Apologies that the CI / CD stuff is such a mess, the preview staging automation is actually an action 😅

-> https://github.com/nodejs/nodejs.dev/blob/master/.github/workflows/upload-to-staging.yml

there isn't really use of a staging branch, which is why there is no content at the root of staging.nodejs.org

I'm on the fence about if we should push the storybook to production... but I'd say it is more a +/- 0... reasonable to try it out and remove it if we decide to not include it.

I requested changes including a rebase and an update to the github aciton. Please feel free to dismiss my review once those are updated. I'll do my best to review this in a timely fashion, but no need to block on me if we can't got those landed in time.

Yeah, while we're on Dev i don't see a reason not to keep it out there. Before release we can probably push it to a subdomain or completely different URL if desired. Certainly is handy for PR preview branches

If this checks pass lets land this and see what happens with both production + an open PR then iterate if things are not working as expected

🕺