github / vscode-codeql Public

Plus fix the associated styling/CSS

…ests

Add unit tests for query history and remote queries

- More explicit test helper module names
- Fix unit test names
- Better sanitization of repo names in tests

Adds structured evaluator logging on a per-query instance to CLI v 2.8.2+. The newline-delimited JSON logs are emitted to `structured-evaluator-log.json` in the directory with other query artifacts, but not consumed by the extension.

Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>

Preemptively add a version number to the query history json file

Co-authored-by: Charis Kyriakou <charisk@users.noreply.github.com>

Adds some tests for reading in the history and manipulating.
There are some more tests to come later. Maybe in another PR, maybe in
this one.

Note that this PR uses a new node 16 API String.prototype.replaceAll.
I think this is ok since vscode ships with node 16. If this causes
problems, I can separate to a different PR and we can discuss there.

Since we are now storing query history on disk, we will need to handle
situations where versions change. For now, there is only version 1. In
the future, we may need to make breaking changes to this format and we
need the flexibility to detect and possibly handle different versions.

In this case, users don't often downgrade their vscode versions, so
most likely, we only need to be forward compatible. Ie- we need to
handle moving from v1 to v2, but not the other way around.

Avoid downloading a result if it already exists

This commit adds a check if a results artifact already exists before
trying to download it again.

This is not a complete solution since the page icon will still have a
download button even if the artifact already exists. In this case,
clicking on it will avoid downloading it a second time.

The next step is to read in the downloaded artifacts and display them
appropriately.

Allow multiple analyses for same repo to be downloaded

Remember remote queries across restarts

Add remote query items to history view

Removes the limitation specified in #1089 where analyses for the same
repo and different queries will overwrite each other.

Remote query items will be stored in query history and will remain
available across restarts.

When the extension is restarted, any `InProgress` remote queries will
be monitored until they complete.

When clicked on, a remote query is opened and its results can be
downloaded. The query text and the query file can be opened from the
history menu. A remote query can be deleted as well, which will purge
all results from global storage.

Limitations:

1. Labels are not editable
2. Running multiple queries that each run on the same repository
   will have conflicting results and there will be errors when trying
   to view the results of the second query. This limitation is not new,
   but it is easier to hit now. See #1089.

Both of these limitations will be addressed in future PRs.

Open query server logger for query errors

…y-info

Refactor query history to handle remote and local

Ensure `--addtional-packs` arg not used for empty workspace

Because errors when running queries tend to have better explanations
in the query server log instead of the extension log, by default open
the query server log for query errors.

…/remote-query-save

Store remote query artifacts in global storage