Sitelet https://web.archive.org/web/20200718072544/https://github.com/parcel-bundler/parcel/pull/4420
Skip to content

/ parcel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit codeframe for parcelrc with malformed json #4420

Merged
merged 3 commits into from Apr 4, 2020
Merged

Emit codeframe for parcelrc with malformed json #4420

merged 3 commits into from Apr 4, 2020

Conversation

@mischnic
Copy link
Member

mischnic commented Apr 2, 2020

↪️ Pull Request

Bildschirmfoto 2020-04-02 um 23 56 26
@height
Copy link

height bot commented Apr 2, 2020

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

You can also use "Close T-X" to automatically close a task when the pull request is merged.
@parcel-benchmark
Copy link

parcel-benchmark commented Apr 2, 2020 •
edited

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 7.27s +259.00ms
Cached 1.86s -89.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 256.00ms -60.00ms 🚀
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 292.00ms +28.00ms ⚠️
dist/legacy/kitchen-sink.32bb4226.js 1.13kb +0.00b 1.52s -83.00ms 🚀
dist/legacy/index.html 709.00b +0.00b 802.00ms -81.00ms 🚀
dist/modern/index.html 709.00b +0.00b 959.00ms +81.00ms ⚠️
dist/legacy/styles.27b3555b.css 29.00b +0.00b 1.51s -89.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/styles.27b3555b.css 29.00b +0.00b 5.00ms -1.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 9.47s -261.00ms
Cached 2.02s +71.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/main/index.js 66.80kb +0.00b 14.00ms -5.00ms 🚀
dist/module/index.js 37.45kb +0.00b 2.00ms -8.00ms 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 2.65m +4.04s
Cached 4.02s +144.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/ak-editor.75898cc3.js 2.52mb +4.00b ⚠️ 1.56m +1.84s
dist/media-viewer.d2ccd27a.js 69.43kb +0.00b 55.72s +42.21s ⚠️
dist/ui.76448be4.js 54.07kb +0.00b 13.04s -40.49s 🚀
dist/Modal.78439f32.js 41.14kb +0.00b 6.62s +514.00ms ⚠️
dist/EmojiPickerComponent.76f01576.js 22.31kb +0.00b 9.33s +661.00ms ⚠️
dist/popup.2e775459.js 18.60kb +0.00b 16.47s -12.40s 🚀
dist/popup.f9b9703d.js 18.06kb +0.00b 18.63s -10.24s 🚀
dist/js.df3d83c1.js 16.35kb +0.00b 2.95s -447.00ms 🚀
dist/popup.f81be909.js 10.01kb +0.00b 16.47s -12.40s 🚀
dist/component.88330652.js 9.69kb +0.00b 3.56s -518.00ms 🚀
dist/16.af921f54.js 3.83kb +0.00b 4.14s -207.00ms 🚀
dist/16.e7d6a9e2.js 3.47kb +0.00b 4.95s -2.61s 🚀
dist/png-chunks-extract.e1590636.js 3.39kb +0.00b 3.56s -518.00ms 🚀
dist/16.d15b9e7e.js 3.36kb +0.00b 4.14s -207.00ms 🚀
dist/16.130f73dc.js 3.30kb +0.00b 4.13s -208.00ms 🚀
dist/16.0e595004.js 3.29kb +0.00b 4.13s -207.00ms 🚀
dist/16.5bc34541.js 3.29kb +0.00b 4.29s -348.00ms 🚀
dist/16.cef2ba64.js 3.29kb +0.00b 3.56s -623.00ms 🚀
dist/16.0a79c8df.js 3.25kb +0.00b 3.56s -517.00ms 🚀
dist/EmojiUploadComponent.fccbfb9a.js 2.40kb +0.00b 9.33s +662.00ms ⚠️
dist/ResourcedEmojiComponent.fa126978.js 2.19kb +0.00b 6.60s +518.00ms ⚠️
dist/component.f45b47b8.js 1.11kb +0.00b 6.60s +518.00ms ⚠️
dist/panel-note.ff7d3847.js 817.00b +0.00b 7.89s +2.69s ⚠️
dist/EmojiPickerComponent.39e7a3dc.js 467.00b +0.00b 9.33s +661.00ms ⚠️
dist/16.bed9f448.js 220.00b +0.00b 3.55s -528.00ms 🚀
dist/16.00a77830.js 220.00b +0.00b 4.08s -263.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/ak-editor.32382a26.js 2.52mb +0.00b 256.00ms +14.00ms ⚠️
dist/pdfRenderer.947b1851.js 1.11mb +0.00b 66.00ms -5.00ms 🚀
dist/smartMediaEditor.b26314ec.js 589.72kb +0.00b 37.00ms -14.00ms 🚀
dist/popup.c100c3b1.js 196.49kb +0.00b 62.00ms -8.00ms 🚀
dist/Toolbar.732cf648.js 100.31kb +0.00b 35.00ms -5.00ms 🚀
dist/EmojiPickerComponent.fcf791f4.js 98.66kb +0.00b 86.00ms -13.00ms 🚀
dist/media-viewer.d2ccd27a.js 69.43kb +0.00b 67.00ms -6.00ms 🚀
dist/card.f5b95391.js 66.86kb +0.00b 68.00ms -9.00ms 🚀
dist/smartMediaEditor.11f0d17c.js 54.12kb +0.00b 38.00ms -14.00ms 🚀
dist/ui.76448be4.js 54.07kb +0.00b 70.00ms -9.00ms 🚀
dist/component.0e07710b.js 45.13kb +0.00b 195.00ms +20.00ms ⚠️
dist/Modal.78439f32.js 41.14kb +0.00b 187.00ms +15.00ms ⚠️
dist/EmojiPickerComponent.76f01576.js 22.31kb +0.00b 84.00ms -6.00ms 🚀
dist/DatePicker.445ecfb4.js 21.49kb +0.00b 87.00ms -15.00ms 🚀
dist/popup.2e775459.js 18.60kb +0.00b 50.00ms -10.00ms 🚀
dist/popup.f9b9703d.js 18.06kb +0.00b 49.00ms -11.00ms 🚀
dist/popup.4d91a72f.js 16.97kb +0.00b 48.00ms -11.00ms 🚀
dist/js.df3d83c1.js 16.35kb +0.00b 185.00ms +14.00ms ⚠️
dist/workerHasher.8c8d4944.js 11.69kb +0.00b 70.00ms -10.00ms 🚀
dist/popup.f81be909.js 10.01kb +0.00b 50.00ms -12.00ms 🚀
dist/component.88330652.js 9.69kb +0.00b 185.00ms +16.00ms ⚠️
dist/EmojiTypeAheadComponent.0a3774ec.js 9.18kb +0.00b 71.00ms -10.00ms 🚀
dist/16.af921f54.js 3.83kb +0.00b 183.00ms +15.00ms ⚠️
dist/component.28a23df0.js 3.43kb +0.00b 188.00ms +15.00ms ⚠️
dist/png-chunks-extract.e1590636.js 3.39kb +0.00b 185.00ms +15.00ms ⚠️
dist/ak-editor.b0c28b13.css 3.38kb +0.00b 34.00ms -5.00ms 🚀
dist/component.7fc48bea.js 3.38kb +0.00b 187.00ms +14.00ms ⚠️
dist/component.1b7004a2.js 3.38kb +0.00b 187.00ms +15.00ms ⚠️
dist/16.d15b9e7e.js 3.36kb +0.00b 183.00ms +16.00ms ⚠️
dist/16.cef2ba64.js 3.29kb +0.00b 184.00ms +15.00ms ⚠️
dist/16.0a79c8df.js 3.25kb +0.00b 184.00ms +15.00ms ⚠️
dist/ResourcedEmojiComponent.fa126978.js 2.19kb +0.00b 196.00ms +20.00ms ⚠️
dist/media-picker-analytics-error-boundary.1cc371c1.js 1.73kb +0.00b 47.00ms -11.00ms 🚀
dist/date.f6cd64d7.js 1.71kb +0.00b 146.00ms -10.00ms 🚀
dist/images.8e099c11.js 1.65kb +0.00b 150.00ms -8.00ms 🚀
dist/feedback.0d296529.js 1.62kb +0.00b 87.00ms -14.00ms 🚀
dist/card.9b39e373.js 1.58kb +0.00b 61.00ms -10.00ms 🚀
dist/workerHasher.7232f7c0.js 1.54kb +0.00b 71.00ms -9.00ms 🚀
dist/list-number.a2d24f13.js 1.44kb +0.00b 134.00ms -8.00ms 🚀
dist/status.b1728075.js 1.44kb +0.00b 91.00ms -27.00ms 🚀
dist/link.6a8e0c3c.js 1.28kb +0.00b 143.00ms -10.00ms 🚀
dist/heading6.10450b67.js 1.28kb +0.00b 88.00ms -14.00ms 🚀
dist/heading3.a9d6d59e.js 1.26kb +0.00b 89.00ms -14.00ms 🚀
dist/heading5.626b484b.js 1.15kb +0.00b 88.00ms -14.00ms 🚀
dist/expand.ee7f7a9d.js 1.13kb +0.00b 87.00ms -14.00ms 🚀
dist/component.f45b47b8.js 1.11kb +0.00b 196.00ms +21.00ms ⚠️
dist/heading2.41836e72.js 1.09kb +0.00b 89.00ms -14.00ms 🚀
dist/mention.998670f9.js 1.04kb +0.00b 132.00ms -9.00ms 🚀
dist/fallback.28908360.js 1.04kb +0.00b 90.00ms -21.00ms 🚀
dist/heading4.9ddc7a23.js 1.04kb +0.00b 88.00ms -14.00ms 🚀
dist/layout.2ff6abe5.js 1.02kb +0.00b 149.00ms -9.00ms 🚀
dist/divider.7cc3bac0.js 1.00kb +0.00b 145.00ms -10.00ms 🚀
dist/quote.a77a04e6.js 1021.00b +0.00b 91.00ms -28.00ms 🚀
dist/decision.199135ec.js 986.00b +0.00b 145.00ms -11.00ms 🚀
dist/panel-warning.abadff6b.js 984.00b +0.00b 131.00ms -8.00ms 🚀
dist/list.fe3a6100.js 954.00b +0.00b 132.00ms -9.00ms 🚀
dist/heading1.0fa8d216.js 952.00b +0.00b 90.00ms -17.00ms 🚀
dist/panel-error.c7bf99b9.js 882.00b +0.00b 132.00ms -8.00ms 🚀
dist/panel.4c7ec8f9.js 873.00b +0.00b 130.00ms +11.00ms ⚠️
dist/table.42ee3ddf.js 865.00b +0.00b 90.00ms -21.00ms 🚀
dist/panel-success.297614d3.js 821.00b +0.00b 131.00ms -9.00ms 🚀
dist/panel-note.ff7d3847.js 817.00b +0.00b 131.00ms -9.00ms 🚀
dist/media-viewer-analytics-error-boundary.13371cfb.js 811.00b +0.00b 62.00ms -9.00ms 🚀
dist/simpleHasher.bb452392.js 503.00b +0.00b 70.00ms -9.00ms 🚀
dist/16.1a6a7bf6.js 220.00b +7.00b ⚠️ 183.00ms +15.00ms ⚠️
dist/16.1a6a7bf6.js 220.00b +7.00b ⚠️ 168.00ms +5.00ms
dist/16.1a6a7bf6.js 220.00b +7.00b ⚠️ 167.00ms +6.00ms
dist/esm.5fb04f45.js 220.00b +7.00b ⚠️ 69.00ms -9.00ms 🚀
dist/media-card-analytics-error-boundary.1a6a7bf6.js 220.00b +7.00b ⚠️ 62.00ms -8.00ms 🚀
dist/dropzone.1a6a7bf6.js 220.00b +7.00b ⚠️ 48.00ms -10.00ms 🚀
dist/clipboard.1a6a7bf6.js 220.00b +7.00b ⚠️ 39.00ms -19.00ms 🚀
dist/browser.1a6a7bf6.js 220.00b +7.00b ⚠️ 39.00ms -13.00ms 🚀
dist/editorView.1a6a7bf6.js 220.00b +7.00b ⚠️ 36.00ms -14.00ms 🚀
dist/index.html 127.00b +0.00b 261.00ms +15.00ms ⚠️

Three.js x4 ✅

Timings

Description Time Difference
Cold 1.33m +1.03s
Cached 4.37s -171.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/entry.js 4.15mb +0.00b 47.00ms +7.00ms ⚠️

Click here to view a detailed benchmark overview.
@mischnic mischnic force-pushed the parcelrc-json5-codeframe branch from 634dddf to c5ea848 Apr 3, 2020
mischnic added 2 commits Apr 2, 2020
@mischnic
Add test
Verified
This commit was signed with a verified signature.
mischnic Niklas Mischkulnig
GPG key ID: 9AB442486F8CDE7B Learn about signing commits
3041779
@mischnic
Emit codeframe for parcelrc with invalid json
Verified
This commit was signed with a verified signature.
mischnic Niklas Mischkulnig
GPG key ID: 9AB442486F8CDE7B Learn about signing commits
Loading status checks…
dcbcb5d
@mischnic mischnic force-pushed the parcelrc-json5-codeframe branch from c5ea848 to dcbcb5d Apr 3, 2020
@DeMoorJasper
DeMoorJasper approved these changes Apr 4, 2020
View changes
@mischnic
Merge branch 'v2' into parcelrc-json5-codeframe
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
18caea6
@mischnic mischnic merged commit f01437e into v2 Apr 4, 2020
8 checks passed
8 checks passed
PR Benchmarks
Details
parcel-bundler.parcel Build #20200404.22 succeeded
Details
parcel-bundler.parcel (Linux node_10_x) Linux node_10_x succeeded
Details
parcel-bundler.parcel (Linux node_12_x) Linux node_12_x succeeded
Details
parcel-bundler.parcel (Windows node_10_x) Windows node_10_x succeeded
Details
parcel-bundler.parcel (Windows node_12_x) Windows node_12_x succeeded
Details
parcel-bundler.parcel (macOS node_10_x) macOS node_10_x succeeded
Details
parcel-bundler.parcel (macOS node_12_x) macOS node_12_x succeeded
Details
@mischnic mischnic deleted the parcelrc-json5-codeframe branch Apr 4, 2020
@mischnic mischnic mentioned this pull request Apr 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeMoorJasper DeMoorJasper

@devongovett devongovett

@wbinnssmith wbinnssmith

@padmaia padmaia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@mischnic @parcel-benchmark @DeMoorJasper
You can’t perform that action at this time.