Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFooter not working correctly #34038
Footer not working correctly #34038
Comments
|
Please tell me if I can be of any help |
|
That's strange. It works fine for me: @ajitsinghkaler, does it happen when you Ctrl+Reload (click the reload button while holding the Ctrl key)? |
|
@gkalpak I 've tried a hard reload I've tried incognito mode and I tried it on Mozilla too getting the same error everywhere. Following are my details. OS Details: Browser(Google Chrome) :Version 78.0.3904.87 (Official Build) (64-bit) Screen Resolution: 1366*768(16:9) |
|
You are right. Our footer can get hidden by the sidenav drawer on some resolutions. I think the solution would be to move the footer inside the Could you create a PR and see if any styles need adjusting? |
|
okay I'll have a go at it. |
|
@gkalpak the footer component is not wrapped in mat-sidebar-container So we may have to put it in the sidebar container but doing so makes a lot of space at the right because of our right side nav component. So just wrapping it up will not do we may have to handle it in a different way with js. |
|
Argh |
|
@gkalpak I tried some things like making small changes in the dom and some styles if I find a solution I'll update you on that. |
|
@gkalpak I think we cannot solve it without using js or we may have to think upon a new structure |
|
Yes, we probably have to restructure things a bit. This is not trivial (neither to implement nor to review) given that we have to ensure that the visual result stays the same (or that any changes are intentional), so I suggest putting it aside for now (since there are higher priority things that need to be sorted out first). In any case, thx for all the time you put into investigating this. |
|
Thanks we can put it in the backlog |


Description
Go to https://angular.io/api/router/ActivatedRoute then the footer is not working responsively.
The side menu is coming above the footer componenet
Anything else relevant?
Related issues: