Sitelet https://web.archive.org/web/20220423170732/https://github.com/nodejs/node/pull/34262
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic: another, another round of quic cleanups #34262

Closed
wants to merge 3 commits into from
Closed

quic: another, another round of quic cleanups #34262

wants to merge 3 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jul 8, 2020 •
edited

Builds on #34247 ... the first 15 commits in this PR are from that one.... that one needs to land first.

This is a WIP, will be adding more commits

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ lib / src labels Jul 8, 2020
@jasnell jasnell force-pushed the quic-cleanups-5 branch 2 times, most recently from d862211 to e36d749 Compare Jul 8, 2020
@jasnell
quic: use less specific error codes
960252f 
Stop the madness. Only you can prevent excessive error code
proliferation.
@jasnell jasnell marked this pull request as ready for review Jul 9, 2020
@jasnell jasnell requested a review from as a code owner Jul 9, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Jul 9, 2020 •
edited by jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/32269/
QUIC CI: https://ci.nodejs.org/job/node-test-commit/39548/

addaleax
addaleax approved these changes Jul 9, 2020
View changes
lib/internal/quic/core.js Show resolved Hide resolved
@jasnell jasnell mentioned this pull request Jul 9, 2020
Closed
4 tasks
jasnell added a commit that referenced this issue Jul 10, 2020
@jasnell
quic: use less specific error codes
5e769b2 
Stop the madness. Only you can prevent excessive error code
proliferation.

PR-URL: #34262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this issue Jul 10, 2020
@jasnell
quic: use Number instead of BigInt for more stats
48a349e 
PR-URL: #34262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell added a commit that referenced this issue Jul 10, 2020
@jasnell
quic: set destroyed at timestamps for duration calculation
c176d5f 
PR-URL: #34262
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell
Copy link
Member Author

@jasnell jasnell commented Jul 10, 2020

Landed in 5e769b2, 48a349e, and c176d5f

@jasnell jasnell closed this Jul 10, 2020
@MylesBorins MylesBorins added the backport-requested-v14.x label Jul 14, 2020
@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Jul 14, 2020

Marked as "backport-requested" because I do not believe quic is on 14.x yet. Should we change the label to "dont-land"?

@jasnell jasnell added dont-land-on-v14.x and removed backport-requested-v14.x labels Jul 14, 2020
@jasnell
Copy link
Member Author

@jasnell jasnell commented Jul 14, 2020

@MylesBorins for the time being, none of the quic related PRs/commits should be pulled into any release lines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax

Assignees
No one assigned
Labels
c++ dont-land-on-v14.x lib / src
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jasnell @nodejs-github-bot @MylesBorins @addaleax